weixin_39524882
weixin_39524882
2020-12-09 00:18

Fixes #964, #965 - Remove validation checks

Remove validation checks for datatype property recursion and same name validation for function block operation name.

该提问来源于开源项目:eclipse/vorto

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

4条回答

  • weixin_39609166 weixin_39609166 5月前

    I’d be careful removing the recursion check as all generators need to be verified that they handle the recursion. Also the vorto perspective has to handle it. Can u make these changes ?

    点赞 评论 复制链接分享
  • weixin_39524882 weixin_39524882 5月前

    Yep, I take care of this. Maybe it is now time for some unit tests for the generators :)

    点赞 评论 复制链接分享
  • weixin_39609166 weixin_39609166 5月前

    HI
    Can you check your PR. It says Merge conflicts. I did quite a bit of changes lately, where I put the editors in a different folder structure. Also I removed the Eclipse Toolset, as we will be not supporting the Eclipse plugins any longer. Instead, I added an initial version of a simple web-based editing functionality in the Vorto Repository (using simple javascript ACE editor).

    点赞 评论 复制链接分享
  • weixin_39524882 weixin_39524882 5月前

    Closing this for now. I open a new PR when I got the time to take care of this change.

    点赞 评论 复制链接分享

相关推荐