weixin_39671509
weixin_39671509
2020-12-09 03:37

removed support for dynamic user generated visit labels

This removes the possibility to enter a custom visit label dynamically when creating a new timepoint. This is to lay the foundation of normalised visits and help the move of visitLabels from the config.xml to the database.

collaterals: the suggestion options that was custom to user generated visitlabels was removed, Deprecation error is thrown id config.xml not updated before going on this branch

reqs: removing the generation, regex, length and suggest tags from the config.xml under the visitLabel section.

To test: - first, before checking out this branch, set the generation to user and confirm that you can enter the visit label manually. - checkout the branch and make sure an error is thrown when config is not modified - change the generation=user to generation = sequence, this should not throw an error but we still recommend to completely remove the tags (this is just to simplify the upgrade for projects already using sequence) - completely remove the tags mentioned above and go through the testplan.md file

该提问来源于开源项目:aces/Loris

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

6条回答

  • weixin_39849254 weixin_39849254 5月前

    conflicts

    点赞 评论 复制链接分享
  • weixin_39671509 weixin_39671509 5月前

    fixed

    点赞 评论 复制链接分享
  • weixin_39671509 weixin_39671509 5月前

    I rebased this one if you want to take a look at it

    点赞 评论 复制链接分享
  • weixin_39671509 weixin_39671509 5月前

    visits normalization can not go through without this being merged first

    点赞 评论 复制链接分享
  • weixin_39671509 weixin_39671509 5月前

    help, not sure which phan rule is breaking

    点赞 评论 复制链接分享
  • weixin_39878855 weixin_39878855 5月前

    Rebase, it's something that was broken in the major branch and is fixed now, it's not from this code..

    
    modules/dicom_archive/php/dicomarchiveanonymizer.class.inc:42 PhanTypeMismatchDeclaredParam Doc-block of $resource in map contains phpdoc param type \LORIS\Data\Instance which is incompatible with the param type \LORIS\Data\DataInstance declared in the signature
    

    (there was a typo where the doc class type wasn't renamed when the class was renamed from Instance to DataInstance..)

    点赞 评论 复制链接分享

相关推荐