weixin_39911916
weixin_39911916
2020-12-09 04:43

Support replying to an ip that is not what is included in the message.

It might happen that the IP from which we receive the message is not what it is included in the message. This is still valid scenario, because swim-js binds its udp socket to all server interfaces. Thus, the outgoing messages can include in the payload a different ip address than the one contained in rinfo.

This PR disables this check.

More details on https://github.com/mrhooray/swim-js/issues/4#issuecomment-184402047.

Fixes #4.

该提问来源于开源项目:mrhooray/swim-js

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

6条回答

  • weixin_39911916 weixin_39911916 5月前

    Locally I'm seeing some spurious failures on "Net can send and receive multiple messages batched over packets", with or without this change.

    点赞 评论 复制链接分享
  • weixin_39911916 weixin_39911916 5月前

    Woow, thanks for the quick merge! :)

    点赞 评论 复制链接分享
  • weixin_39911916 weixin_39911916 5月前

    When do you expect to publish this change? We are currently targeting my dev branch :).

    点赞 评论 复制链接分享
  • weixin_39845113 weixin_39845113 5月前

    just published v0.3.0

    点赞 评论 复制链接分享
  • weixin_39911916 weixin_39911916 5月前

    Awesome, thanks!!! Il giorno gio 25 feb 2016 alle 20:07 Rui Hu notifications.com ha scritto:

    https://github.com/mcollina just published v0.3.0

    — Reply to this email directly or view it on GitHub https://github.com/mrhooray/swim-js/pull/5#issuecomment-188933900.

    点赞 评论 复制链接分享
  • weixin_39911916 weixin_39911916 5月前

    Thanks!!!

    点赞 评论 复制链接分享

相关推荐