weixin_39643338
weixin_39643338
2020-12-09 04:56

remove limits for pods

follow on to my previous PR to make components run as Burstable, without limits

该提问来源于开源项目:openshift/cluster-monitoring-operator

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

6条回答

  • weixin_39900045 weixin_39900045 5月前

    [APPROVALNOTIFIER] This PR is NOT APPROVED

    This pull-request has been approved by: sjenning To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: s-urbaniak

    If they are not already assigned, you can assign the PR to them by writing /assign -urbaniak in a comment when ready.

    The full list of commands accepted by this bot can be found here.

    The pull request process is described here

    Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-monitoring-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
    点赞 评论 复制链接分享
  • weixin_39643338 weixin_39643338 5月前

    ugh, i did it again. these are generated files that i can't find the source for.

    点赞 评论 复制链接分享
  • weixin_39643338 weixin_39643338 5月前

    doing this in https://github.com/openshift/prometheus-operator/pull/20

    点赞 评论 复制链接分享
  • weixin_39944595 weixin_39944595 5月前

    this one is a little more tricky :p These manifests are likewise all generated from jsonnet, however they come mostly from kube-prometheus, a distribution of monitoring components that we put together and are a dependency of this project [0]. The correct way to do this would be to write a mixin that removes limits for any object used in cluster monitoring operator. (We don’t want to remove the limits upstream in the kube-prometheus distro and other projects we are importing as they have valid use cases for limits). Please let me know if you need any help or want me to take over this and I can make a PR tomorrow.

    [0] https://github.com/openshift/cluster-monitoring-operator/blob/master/jsonnet/main.jsonnet#L1

    点赞 评论 复制链接分享
  • weixin_39944595 weixin_39944595 5月前

    Note: kube-prometheus is being imported from the upstream repo, not the openshift fork https://github.com/openshift/cluster-monitoring-operator/blob/master/jsonnet/jsonnetfile.json#L7

    点赞 评论 复制链接分享
  • weixin_39944595 weixin_39944595 5月前

    finished this in #273

    点赞 评论 复制链接分享

相关推荐