weixin_39864101
2020-12-09 07:30 阅读 0

Submission Hyperlink

Describe the bug When a journal puts an HTML hyperlink to open a new tab in the submission guideline the way the URL function differs on the journal front end and within the submission steps.

To Reproduce Front end (User facing Submission page) - when clicked will open a new window as dictated by the HTML code.

Backend (Author submission step) - If an author were to click on the hyperlink in the submission process it opens the page in the same window.

What application are you using? OJS 3.2

Additional Information The hyperlink within the submission process should ideally allow for the link to open in a new window or have a warning that you're leaving the current page.

该提问来源于开源项目:pkp/pkp-lib

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

6条回答 默认 最新

  • weixin_39617113 weixin_39617113 2020-12-09 07:30

    , could you include a few screenshots so I'm sure I'm looking for the right thing? Thanks!

    点赞 评论 复制链接分享
  • weixin_39864101 weixin_39864101 2020-12-09 07:30

    Hi ,

    Here are two recordings of this in action. The hyperlink gets added by the user in Settings>Workflow>Submission>Checklist (if this is helpful)

    Front end Frontend Submission hyperlink

    Backend

    Backend Submission hyperlink

    点赞 评论 复制链接分享
  • weixin_39831001 weixin_39831001 2020-12-09 07:30

    Confirmed. This is because |strip_unsafe_html is applied in the backend but not the frontend.

    What do you think, Alec? Since this is input from a manager or admin, is it safe without strip_unsafe_html? Or can we extend strip_unsafe_html to allow target attributes?

    点赞 评论 复制链接分享
  • weixin_39617113 weixin_39617113 2020-12-09 07:30

    I would support removing strip_unsafe_html as this is a journal setting, and generally we don't filter data that's entered by site admin or manager users.

    点赞 评论 复制链接分享
  • weixin_39831001 weixin_39831001 2020-12-09 07:30

    PRs: https://github.com/pkp/pkp-lib/pull/6280 https://github.com/pkp/pkp-lib/pull/6281 (stable-3_2_1)

    Tests: https://github.com/pkp/ojs/pull/2880

    点赞 评论 复制链接分享
  • weixin_39831001 weixin_39831001 2020-12-09 07:30

    Merged to master and stable-3_2_1.

    点赞 评论 复制链接分享

相关推荐