weixin_39616348
weixin_39616348
2020-12-09 09:39

fix treetop to version 1.5.1

Pins the treetop gem version to =1.5.1

该提问来源于开源项目:edelight/chef-solo-search

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

8条回答

  • weixin_39575937 weixin_39575937 4月前

    Wouldn't it be a better idea to have '>= 1.5.1'?

    点赞 评论 复制链接分享
  • weixin_39616348 weixin_39616348 4月前

    The purpose is to prevent bugs being induced into the cookbook by new builds of treetop (as was the occasion last week, Issue #57 ). It's really up to the maintainers of the cookbook. In my opinion, fixing the version of a critical gem install is a good practice, especially with a deployment too.

    点赞 评论 复制链接分享
  • weixin_39560002 weixin_39560002 4月前

    :+1: to fixing the gem version. We can upgrade it as needed.

    点赞 评论 复制链接分享
  • weixin_39575937 weixin_39575937 4月前

    OK then. Should we merge then?

    点赞 评论 复制链接分享
  • weixin_39616348 weixin_39616348 4月前

    The only other caveat I see would be another cookbook requiring > 1.5.1 (I'm not sure what the behavior would be when trying to re-install the gem on the chef sandbox ruby, it might work fine). I don't know how many cookbooks require treetop parser though, especially new builds.

    点赞 评论 复制链接分享
  • weixin_39560002 weixin_39560002 4月前

    I think we'll cross that bridge when we reach it. when there's a conflict, we'll test the alternate version given that we've been burned by treetop 1.5.0

    点赞 评论 复制链接分享
  • weixin_39560002 weixin_39560002 4月前

    didn't want to step on your toes!

    点赞 评论 复制链接分享
  • weixin_39575937 weixin_39575937 4月前

    no problem! Thank you for your continued work, which greatly helps make chef-solo-search awesome!

    点赞 评论 复制链接分享

相关推荐