weixin_39862899
weixin_39862899
2020-12-09 09:41

Fix EZP-21636: Hinclude sub-requests are broken since EZP-21631 fix

https://jira.ez.no/browse/EZP-21636

Fixes a regression from d6e3f67

Since Symfony 2.3.5, $absolute has been added to generateFragmentUri() (see EZP-21631 and https://github.com/symfony/symfony/issues/8458). When I fixed EZP-21631, I just forgot to pass this new argument to the parent method.

$absolute is a boolean indicating if we want to generate an ablsoute fragment link.

该提问来源于开源项目:ezsystems/ezpublish-kernel

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

8条回答

  • weixin_39862899 weixin_39862899 4月前

    Note that Travis fail is not related to this PR.

    点赞 评论 复制链接分享
  • weixin_39573512 weixin_39573512 4月前

    If the PR is about passing $include as an argument, it seems to be getting the job done. In that case, +1 :-)

    点赞 评论 复制链接分享
  • weixin_39633134 weixin_39633134 4月前

    +1

    点赞 评论 复制链接分享
  • weixin_39862847 weixin_39862847 4月前

    +1

    点赞 评论 复制链接分享
  • weixin_39862899 weixin_39862899 4月前

    what ?

    点赞 评论 复制链接分享
  • weixin_39699070 weixin_39699070 4月前

    +1

    Didn't get that either. Is this reported? https://travis-ci.org/ezsystems/ezpublish-kernel/jobs/12265843

    点赞 评论 复制链接分享
  • weixin_39846089 weixin_39846089 4月前

    Is this reported? https://travis-ci.org/ezsystems/ezpublish-kernel/jobs/12265843

    it is not, I'll create an issue. We should really start to report these and weed them out.

    点赞 评论 复制链接分享
  • weixin_39699070 weixin_39699070 4月前

    ok, ping me with it on skype os I can add it to backlog.

    点赞 评论 复制链接分享