weixin_39566593
weixin_39566593
2020-12-09 10:33

Icons: Feedback icons missing

eBay Skin Version: 5.1.0

  1. The DS6 svg module mentions feedback related icons feedback-positiveetc. , http://ebay.github.io/skin/ds6/#svg, but they are missing from icons.svg.

  2. Shouldn't there feedback related icons in background/inline svg as well? The mixins/classes are missing in icon.less as well .

该提问来源于开源项目:eBay/skin

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

9条回答

  • weixin_39517054 weixin_39517054 5月前

    Thanks for raising this issue. Is this a blocker or do you have a workaround for now?

    点赞 评论 复制链接分享
  • weixin_39566593 weixin_39566593 5月前

    not a blocker. Workaround is to use DS4 mixins for now.

    let me know i can send a pr.

    点赞 评论 复制链接分享
  • weixin_39658318 weixin_39658318 5月前

    Feel free if it's a small set of fixes!

    点赞 评论 复制链接分享
  • weixin_39517054 weixin_39517054 5月前

    I don't see these feedback icons in the DS6 Sketch source, so I think they are leftovers from DS4 and have not yet been updated for DS6.

    screen shot 2018-10-24 at 10 44 23 am

    I think it's best maybe if I just remove these references from the DS6 site for now. What do you think?

    点赞 评论 复制链接分享
  • weixin_39566593 weixin_39566593 5月前

    , instead of removing, can we get the DS team to port them over to DS6. Our app currently uses those.

    点赞 评论 复制链接分享
  • weixin_39658318 weixin_39658318 5月前

    My fault!! My comments were for a different issue entirely.

    点赞 评论 复制链接分享
  • weixin_39658318 weixin_39658318 5月前

    But ... these are purposefully not in DS6. Can you reach out to the DS team to confirm what you should do?

    点赞 评论 复制链接分享
  • weixin_39517054 weixin_39517054 5月前

    Agree with Sean, they have been purposefully removed. For now I'll remove the reference. If Design Team want them in DS6 we can create a new issue.

    点赞 评论 复制链接分享
  • weixin_39517054 weixin_39517054 5月前

    Refs removed in 6.1.0-prerebase branch.

    点赞 评论 复制链接分享

相关推荐