weixin_39623082
weixin_39623082
2020-12-09 11:13

Feature Application Launcher 3.x

Application launcher directive

Currently making use of CSS/Styling from base PatternFly 3.x, PR pending:

  • https://github.com/patternfly/patternfly/pull/632

Samples

  • https://rawgit.com/cdcabrera/patternfly/Feature-AppLauncher-3x-dist/dist/tests/application-launcher-nav.html

screen shot 2017-04-19 at 3 54 05 pm

-phillips-18

该提问来源于开源项目:patternfly/angular-patternfly

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

9条回答

  • weixin_39922769 weixin_39922769 5月前

    Hi, would it be possible to show the app. launcher icon on the navbar-pf black background, the same way pfNotificationDrawer does? That is most likely where it will be placed most often. Ex: image

    点赞 评论 复制链接分享
  • weixin_39623082 weixin_39623082 5月前

    Indeed, applying it for a demo/example on the navbar-pf background, good idea can do

    点赞 评论 复制链接分享
  • weixin_39623082 weixin_39623082 5月前

    Integrating styling into base PatternFly. Once example for the app launcher is updated and base PatternFly styling integrated will convert PR to non-review

    点赞 评论 复制链接分享
  • weixin_39922769 weixin_39922769 5月前

    Hi, just a heads up that OpenShift Console/Catalog is waiting on this PR in order to add the App. Launcher to the console application. I understand that this PR is waiting on PR in base PF.

    点赞 评论 复制链接分享
  • weixin_39636987 weixin_39636987 5月前

    PatternFly 3.24.0 has been released. Is this PR ready to merge?

    点赞 评论 复制链接分享
  • weixin_39636987 weixin_39636987 5月前

    commented via slack that this PR is ready to merge.

    点赞 评论 复制链接分享
  • weixin_39623082 weixin_39623082 5月前

    Can do on the naming as well "application-launcher"

    点赞 评论 复制链接分享
  • weixin_39922769 weixin_39922769 5月前

    where the component/directive should live, currently placed under navigation

    ok

    preference in component/directive naming

    prefer 'pfApplicationLauncher'

    any recommendations on isolated scope properties

    Seem ok

    have a rough of the Less/CSS was aiming to place within Patternfly, but dependent on need can place where ever recommended

    Best to have Less/CSS in base Patternfly. Is there a base PatternFly app launcher? You can add the Less/CSS to angular-patternfly initially, then put up a PR to add the Less/CSS to base Patternfly. Then once that is merged, another PR to remove the Less/CSS from angular-patternfly, fun huh? ;-)

    点赞 评论 复制链接分享
  • weixin_39922769 weixin_39922769 5月前

    Pls be sure to squash all those commits before merging! -thanks

    点赞 评论 复制链接分享

相关推荐