weixin_39706127
weixin_39706127
2020-12-09 11:14

Feature AVL dynamic stability

This PR contains the following: Inclusion of Addresses Issue #314 - Dynamic Stability Module of AVL - A consistent definition of Control Surfaces - Correction of Regression vehicle scripts - Correction of Fidelity Zero Stabili

ty so results are consistent with AVL

该提问来源于开源项目:suavecode/SUAVE

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

9条回答

  • weixin_39630095 weixin_39630095 5月前

    This is now resolved.

    点赞 评论 复制链接分享
  • weixin_39629969 weixin_39629969 5月前

    Coverage Status

    Coverage increased (+1.3%) to 77.093% when pulling 89a1a7b908c631a4f0c2360f6b31bf8dc17505eb on feature-AVL_dynamic_stability into f58aa5c2bd3b0004ea9acbabdd37f9d3df373d8e on develop.

    点赞 评论 复制链接分享
  • weixin_40005542 weixin_40005542 5月前

    I'm going to hold off on reviewing again until all regressions pass.

    点赞 评论 复制链接分享
  • weixin_39706127 weixin_39706127 5月前

    responses to the two high-level comment by
    Do we need the ~100 regression txt files added to the repo? In short yes. Since we are not running AVL, the files created have to be generated and saved for each flight condition. Typically, they are automatically deleted from the run directory. It seems like identical flaps and slats are added to many of the aircraft. What's the reason for this? Many of the aircraft define flap and slat angles without defining the geometry. With the new way how these control surfaces of defined. There needs to be some predefined component (as with the case of wings, fuselage etc)

    点赞 评论 复制链接分享
  • weixin_39630095 weixin_39630095 5月前

    It looks like you added several xml files in one of the last commits. Was that intentional?

    点赞 评论 复制链接分享
  • weixin_39630095 weixin_39630095 5月前

    Almost there but there's still a few xml and iml files in here.

    点赞 评论 复制链接分享
  • weixin_40005542 weixin_40005542 5月前

    , please comment to make sure you have approved this.

    点赞 评论 复制链接分享
  • weixin_39630095 weixin_39630095 5月前

    There's still a stray .iml and .gitignore file in here that need to be removed:

    https://github.com/suavecode/SUAVE/tree/develop/trunk/SUAVE/.idea

    点赞 评论 复制链接分享
  • weixin_40005542 weixin_40005542 5月前

    Please leave more descriptive commits than PR updated 5

    点赞 评论 复制链接分享

相关推荐