weixin_39923110
weixin_39923110
2020-12-09 12:51

Remove user-generated PSCID structure?

There's a note in Utility about removing user-generated PSCIDs.

https://github.com/aces/Loris/blob/5aa861f791f6fb68c835c5a17b5e1564b0e40240/php/libraries/Utility.class.inc#L297-L311

Is this something that projects are using? If not, can we delete it?

该提问来源于开源项目:aces/Loris

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

11条回答

  • weixin_39573136 weixin_39573136 5月前

    I'd down-vote this. It runs counter to many studies' actual workflow. Subjects almost always have an internal ID informally assigned before they're registered in LORIS, because the order of registration in LORIS is not the same as the intake order (i.e. when recruiting/recording their name, phone, etc). This is because LORIS input often happens only when a scheduled visit/timepoint is imminent, or they fill out surveys/testing or sign consent.
    Ideally the intake ID can suggest the PSCID (Subject #7 -> PSCID MTL0007) to minimize risk of confusion for the study coordinator, and would not mandatorily be sequentially assigned.

    点赞 评论 复制链接分享
  • weixin_39878855 weixin_39878855 5月前

    you're the one who added that note in 31dacf4e10

    点赞 评论 复制链接分享
  • weixin_39923110 weixin_39923110 5月前

    That's how Git lays it out but if you dig a little that attribution goes to a PR containing a commit written by Justin Ng (and also ). I think I just made the PR off of someone else's branch.

    Do you have any idea why that note was referring to? Is this something we want to keep in LORIS?

    点赞 评论 复制链接分享
  • weixin_39878855 weixin_39878855 5月前

    I don't know what the note is referring to. do you? You commented on the PR that linked to above.

    点赞 评论 复制链接分享
  • weixin_39878855 weixin_39878855 5月前

    I sent a PR to just remove the note unless we come up with someone who knows what it's talking about.

    点赞 评论 复制链接分享
  • weixin_39671509 weixin_39671509 5月前

    I didnt comment on that part. I understand it as, this is necessary only for usergenerated PSCIDs. but it does make it sound like the goal is to remove that feature and I dont think we should.

    Maybe we should move it to the PSCID class when It gets created ?

    点赞 评论 复制链接分享
  • weixin_39878855 weixin_39878855 5月前

    Why would the note be less confusing in the theoretical PSCID class?

    点赞 评论 复制链接分享
  • weixin_39752800 weixin_39752800 5月前

    my name's only on there because I rebased for you. but looks like the line came from https://github.com/aces/Loris/pull/2889/files

    点赞 评论 复制链接分享
  • weixin_39878855 weixin_39878855 5月前

    So far we're still batting .000 for people who understand what the note is referring to..

    点赞 评论 复制链接分享
  • weixin_39752800 weixin_39752800 5月前

    lol if we have no plans to remove user-generated PSCID support, then we should probably just delete the note

    点赞 评论 复制链接分享
  • weixin_39923110 weixin_39923110 5月前

    Closing this and #5229 removes the note.

    点赞 评论 复制链接分享

相关推荐