weixin_39564036
weixin_39564036
2020-12-09 15:08

[SDL-0253] New vehicle data StabilityControlsStatus

Fixes #1449

This PR is to add new vehicle data StabilityControlsStatus to know if stability controls like ESC, Traction Control etc. are active.

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

  • [x] I have verified that I have not introduced new warnings in this PR
  • [x] I have run the unit tests with this PR

Unit Tests

New tests added, old tests fixed to process updated data. Tested on my local machine using iPhone-8 simulator running iOS-13.0 As always only 5 SDLLockScreenViewControllerSnapshotTests tests failed and it has nothing to do with the PR, the rest passed successfully.

Core Tests

None

Summary

detailed description on sdl evolution

Changelog

Breaking Changes

None

Enhancements
Bug Fixes

Tasks Remaining:

CLA

该提问来源于开源项目:smartdevicelink/sdl_ios

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

13条回答

  • weixin_39564036 weixin_39564036 5月前

    Hello, could you please review?

    点赞 评论 复制链接分享
  • weixin_39689377 weixin_39689377 5月前

    please make sure the feedback provided in https://github.com/smartdevicelink/sdl_ios/pull/1693#pullrequestreview-450716620 is reflected in this PR as well, and let us know once this has been confirmed/ready for review. Thank you!

    点赞 评论 复制链接分享
  • weixin_39564036 weixin_39564036 5月前

    Hello , I have applied the feedback provided in #1693 (review) in this PR as well. Could you please review? Thank you!

    点赞 评论 复制链接分享
  • weixin_39861918 weixin_39861918 5月前

    , we will not be reviewing this PR again until this PR is fully reviewed and merged in order to reduce the amount of time that we are spending in giving the same review comments and so that you have an approved PR to know exactly what we're looking for. We ask that you place your focus on that PR.

    点赞 评论 复制链接分享
  • weixin_39945679 weixin_39945679 5月前

    Codecov Report

    Merging #1691 into develop will increase coverage by 0.03%. The diff coverage is 97.36%.

    diff
    @@             Coverage Diff             @@
    ##           develop    #1691      +/-   ##
    ===========================================
    + Coverage    84.11%   84.15%   +0.03%     
    ===========================================
      Files          418      419       +1     
      Lines        21471    21531      +60     
    ===========================================
    + Hits         18060    18119      +59     
    - Misses        3411     3412       +1     
    
    点赞 评论 复制链接分享
  • weixin_39564036 weixin_39564036 5月前

    Hello , could you please review the latest changes? Thank you.

    点赞 评论 复制链接分享
  • weixin_39861918 weixin_39861918 5月前

    Hi , if you will look at my last comment. This PR will not be reviewed until the other referenced PR is complete.

    点赞 评论 复制链接分享
  • weixin_39612877 weixin_39612877 5月前

    The Window Status PR #1694 was approved and merged. I can see that there are now a few files that have merge conflicts with the files on the develop branch. Can you fix the merge conflicts and tag me when this PR is ready for review. Thanks.

    点赞 评论 复制链接分享
  • weixin_39564036 weixin_39564036 5月前

    Hello . I have merged with develop, could you please review?

    点赞 评论 复制链接分享
  • weixin_39861918 weixin_39861918 5月前

    , please tag me when this is ready for review again!

    点赞 评论 复制链接分享
  • weixin_39861918 weixin_39861918 5月前

    I want to let you know that I will take care of the merge conflicts when the merge occurs because it requires specific steps to fix. Please just fix the issues outlined above and not the merge conflicts.

    点赞 评论 复制链接分享
  • weixin_39564036 weixin_39564036 5月前

    Hello , I have applied all proposed changes, could you please review? Thank you.

    点赞 评论 复制链接分享
  • weixin_39564036 weixin_39564036 5月前

    could you please review it?

    点赞 评论 复制链接分享

相关推荐