weixin_39858298
weixin_39858298
2020-12-26 00:14

Conflict with a python file name of the core

In a past pull-request #44, two files from the SolidMechanicsApplication were copied to the core and modified internally to do different things:

assign_scalar_to_conditions_process.py assign_vector_to_conditions_process.py

Then the name of one of the files was changed to avoid conflicts but one file remained with the same name. So now there are

assign_scalar_to_conditions_process.py assign_vector_to_condition_process.py

For consistency the first file must be renamed as

assign_scalar_to_condition_process.py

This will solve the conflict that exists now, because the file of the SolidMechanicsApplication is hidden by the one in the core.

该提问来源于开源项目:KratosMultiphysics/Kratos

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

4条回答

  • weixin_39760433 weixin_39760433 4月前

    Hi -m-carbonell!!

    After a short discussion with , we think that the best way to proceed is to rename the core processes in the way below:

    • assign_scalar_to_conditions_process.py to assign_scalar_variable_to_conditions_process.py
    • assign_vector_to_condition_process.py to assign_vector_variable_to_conditions_process.py

    In this way the name convention is the same as the other core processes and the conflicts with the SolidMechanicsApplication are avoided. Is this ok?

    (I will do the changes ASAP)

    点赞 评论 复制链接分享
  • weixin_39858298 weixin_39858298 4月前

    For me it is ok. Thank you!

    点赞 评论 复制链接分享
  • weixin_39760433 weixin_39760433 4月前

    Done!! -m-carbonell, would you mind running your tests to be sure that everything is ok? Thank you! (PR #768, branch name: fix-condition-processes-naming)

    点赞 评论 复制链接分享
  • weixin_39858298 weixin_39858298 4月前

    All tests worked, thank you !

    点赞 评论 复制链接分享

相关推荐