weixin_39606361
weixin_39606361
2020-12-26 07:29

Add Zipkin API V2 Reporter

Expands span reporter selection by breaking out Reporter into base QueueReporter class and using reporting method-specific ThriftReporter and ZipkinV2Reporter. Also breaks LocalAgentSender into two classes including LocalAgentReader for ThriftReporter only usage of TBufferedTransport.

These changes allow users to continue reporting spans oob to the local jaeger-agent but with the option of reporting to Zipkin backend.

In the spirit of https://github.com/jaegertracing/jaeger-client-java/pull/399 and https://github.com/jaegertracing/jaeger-client-go/pull/310

Signed-off-by: Ryan Fitzpatrick

该提问来源于开源项目:jaegertracing/jaeger-client-python

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

5条回答

  • weixin_39945679 weixin_39945679 4月前

    Codecov Report

    Merging #197 into master will increase coverage by 0.31%. The diff coverage is 92.3%.

    Impacted file tree graph

    diff
    @@            Coverage Diff             @@
    ##           master     #197      +/-   ##
    ==========================================
    + Coverage   94.75%   95.06%   +0.31%     
    ==========================================
      Files          25       26       +1     
      Lines        1773     1926     +153     
      Branches      224      256      +32     
    ==========================================
    + Hits         1680     1831     +151     
    + Misses         60       54       -6     
    - Partials       33       41       +8
    

    | Impacted Files | Coverage Δ | | |---|---|---| | jaeger_client/local_agent_net.py | 95.65% <100%> (+0.3%) | :arrow_up: | | crossdock/server/endtoend.py | 100% <100%> (ø) | :arrow_up: | | jaeger_client/config.py | 93.15% <90%> (+2.46%) | :arrow_up: | | jaeger_client/zipkin_v2.py | 91% <91%> (ø) | | | jaeger_client/reporter.py | 95.31% <94.87%> (+3.43%) | :arrow_up: |

    Continue to review full report at Codecov.

    Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00d3d4a...ce6fb0b. Read the comment docs.

    点赞 评论 复制链接分享
  • weixin_39606361 weixin_39606361 4月前

    I've increased test coverage for all proposed changes, including some potentially overreaching reporter tests. Apologies for the churn and any feedback would be greatly appreciated.

    点赞 评论 复制链接分享
  • weixin_39606361 weixin_39606361 4月前

    -adder and , in light of https://github.com/jaegertracing/jaeger/issues/925 understandably preventing these changes from being accepted, if a short term requirement is a thrift over http reporter in the client do you think it's reasonable for me to: 1. Attempt to add the append and flush methods to https://github.com/jaegertracing/jaeger-client-python/pull/186 for that to land. 2. Propose an HTTPSender, while using the LocalAgentReader distinction proposed in this PR?

    点赞 评论 复制链接分享
  • weixin_39611765 weixin_39611765 4月前

    I think that'd be great.

    点赞 评论 复制链接分享
  • weixin_39606361 weixin_39606361 4月前

    Fixing the issues found in integration.

    edit: Issues resolved.

    点赞 评论 复制链接分享

相关推荐