weixin_39881760
weixin_39881760
2020-12-26 09:15

Test for TokenCompatSubscriber rendering token with custom token

Overview

This is a test to demonstrate the issue found in #14633 contact.email_greeting won't be rendered if a custom contact token inserted.

Before

No test cover for TokenCompatSubscriber

After

Some tests for TokenCompatSubscriber

Comments

Agileware ref: CIVICRM-1339

该提问来源于开源项目:civicrm/civicrm-core

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

5条回答

  • weixin_39851008 weixin_39851008 4月前

    (Standard links)

    点赞 评论 复制链接分享
  • weixin_39881760 weixin_39881760 4月前

    ping

    点赞 评论 复制链接分享
  • weixin_39950081 weixin_39950081 4月前

    jenkins, test this please

    (it should fail)

    点赞 评论 复制链接分享
  • weixin_39760433 weixin_39760433 4月前

    -pengyi This is a great idea. The test generally reads nicely. :+1:

    I guess the main question is sequencing of merge -- if the change is intended to show a fail, then do we wait for a corresponding patch before merging? (I think it's OK to merge a failing-test if there's work in progress to resolve it before the freeze/release.)

    点赞 评论 复制链接分享
  • weixin_39881760 weixin_39881760 4月前

    Close based on #14633

    点赞 评论 复制链接分享

相关推荐