weixin_39522408
weixin_39522408
2020-12-26 18:15

Remove skip validation for spot checks

When the spot checks are run, the options and arch are generally a supported list for the machine type or the test selected. Depending on the type of spot check, the options and/or arch may or may not be needed for the devices / compiler selected. As a result, the places where CMake validates that the options and arch are consistent with the devices and compilers must disable the option/arch and print a warning rather than error out -- as this will cause the test to fail.

Adding an option to skip validation and enabling that option when spot check is selected. Other scenarios are expected to be a 1 to 1 mapping so the skip validation shouldn't be necessary (I hope)

该提问来源于开源项目:kokkos/kokkos

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

5条回答

  • weixin_39522408 weixin_39522408 4月前

    This appears to already be resolved, so using this issue to track cleanup of the cm_ test scripts

    点赞 评论 复制链接分享
  • weixin_39838829 weixin_39838829 4月前

    What place specifically is causing the error? We changed the behavior last week.

    点赞 评论 复制链接分享
  • weixin_39522408 weixin_39522408 4月前

    see previous comment...

    点赞 评论 复制链接分享
  • weixin_39838829 weixin_39838829 4月前

    This appears to already be resolved, so using this issue to track cleanup of the cm_ test scripts

    Close then?

    点赞 评论 复制链接分享
  • weixin_39522408 weixin_39522408 4月前

    well, I still have to clean up the scripts to remove the unnecessary validation options

    点赞 评论 复制链接分享

相关推荐