weixin_39781209
2020-12-27 05:26 阅读 5

Webhook update

Fix vcx_update_webhook_url to update the notification webhook settings not only locally, but also on the agency. Update nodejs wrapper implementation to support the new version by making the call asynchronous.

该提问来源于开源项目:hyperledger/indy-sdk

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

6条回答 默认 最新

  • weixin_39781209 weixin_39781209 2020-12-27 05:26

    "Everynym guy's" feedback I received via which I based the last two commits on:

    UPDATE_CONFIGS is only used for enterprise's 'name' and 'logo url' (even though that api may accept any string as key and value, it won't be utilized for any other purpose if you want to use UPDATE_COM_METHOD to register http endpoint, then the 'type' should be 2 (for push notification, the type is 1)

    
    {
       : {name: "UPDATE_COM_METHOD", "version": "1.0"},
       "comMethod": {
          "id": ...,
          "type": 2,
          "value": 
       }
    }
    
    点赞 评论 复制链接分享
  • weixin_39852953 weixin_39852953 2020-12-27 05:26

    -Stas let me re-phrase the problem, to check if I got it correctly.

    In Aries flow there is no trigger to apply CONFIG_WEBHOOK_URL if it was set by provisioning + init. In non-aries it was triggered by new connection. And now you are suggesting to define vcx_init as a trigger for Aries flow

    点赞 评论 复制链接分享
  • weixin_39788740 weixin_39788740 2020-12-27 05:26

    In Aries flow there is no trigger to apply CONFIG_WEBHOOK_URL if it was set by provisioning + init. In non-aries it was triggered by new connection

    That's correct. In case of Aries VCX, the webhook_url value passed to vcx_init is I believe never utilized.

    And now you are suggesting to define vcx_init as a trigger for Aries flow Yes, either: - utilize webhook_url and set it on vcx_init in Aries (or maybe regardless of protocol?), - or alternatively consider webhook_url in config/agent provison deprecated and leave it completely up to responsibility of consumer of libvcx api to call vcx_update_webhook_url manually.

    点赞 评论 复制链接分享
  • weixin_39852953 weixin_39852953 2020-12-27 05:26

    -Stas ok, thanks for clarifications. I'm fine with both options

    点赞 评论 复制链接分享
  • weixin_39788740 weixin_39788740 2020-12-27 05:26

    based on Ryan's answer, is this is good to go? Dummy cloud agency is also not utilizing id, just reads it and writes it back to response. Are there any other concerns regard this PR?

    点赞 评论 复制链接分享
  • weixin_39852953 weixin_39852953 2020-12-27 05:26

    -Stas based on Ryan's answer I would say "no other concerns, fill free to merge the PR"

    点赞 评论 复制链接分享

相关推荐