weixin_39788792
weixin_39788792
2020-12-27 19:32

Implement update/delete, enable/disable schedule

  • add meta columns to schedule store
  • add delete mark column to job queue;
  • implement enable/disable/delete/update;
  • update test cases;
  • refactor program life cycle service

该提问来源于开源项目:cdapio/cdap

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

7条回答

  • weixin_39526651 weixin_39526651 3月前

    LGTM.

    点赞 评论 复制链接分享
  • weixin_39788792 weixin_39788792 3月前

    I addressed the last comment and squashed the commits. Waiting for one more build before merging

    点赞 评论 复制链接分享
  • weixin_39788792 weixin_39788792 3月前

    please do that. I am not sure why it does not fails builds.

    However, the last build for this branch failed with a conflict (409) in the after() method of the WorkflowHttpHandlerTest, when deleting the namespace as part of cleanup. Not sure why delete would throw a ConflictException... wouldn't it be a NotFoundException if it were caused by this? https://builds.cask.co/browse/CDAP-RUT1005-9/test. Also I cannot reproduce that locally.

    Starting another build.

    点赞 评论 复制链接分享
  • weixin_39683172 weixin_39683172 3月前

    I don't think it has a test yet. I can also open a separate PR to fix this and cleanup the old scheduler.

    点赞 评论 复制链接分享
  • weixin_39788792 weixin_39788792 3月前

    that may be a valid concern... but should not be a part of this PR? This was done a few PRs ago when the Scheduler refactoring was done? Do we have a test case that would uncover that?

    点赞 评论 复制链接分享
  • weixin_39526651 weixin_39526651 3月前

    Seems like there's a bug when suspending/resuming schedules created with the new API. This is because AbstractSchedulerService#resume calls getSchedulerForSchedule, which looks up the schedule in the app spec, and then throws ScheduleNotFoundException.

    点赞 评论 复制链接分享
  • weixin_39788792 weixin_39788792 3月前

    I addressed the comments, please have another look.

    点赞 评论 复制链接分享

为你推荐