weixin_39722188
weixin_39722188
2020-12-27 23:31

Just big sleep to allow VM to shut off and hopefully avoid intermitte…

We believe that there is a race between docker stop and docker rm. Because we have not implemented containerWait yet, our docker rm implementation immediately tries to rm a vm that might still be powered on.

该提问来源于开源项目:vmware/vic

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

7条回答

  • weixin_39659837 weixin_39659837 4月前

    : this requires your review before merge.

    点赞 评论 复制链接分享
  • weixin_39659837 weixin_39659837 4月前

    potential workaround the test failures seen from #1822 and #1823

    点赞 评论 复制链接分享
  • weixin_39915815 weixin_39915815 4月前

    Firstly that's a VERY long timeout. I'm not sure how many minutes that'll add to the integration tests but it'll be a lot. Secondly I don't think it'll actually work - I believe there are two problems: #1870 and another one in the containerVM itself, possibly #1837). The latter is hard to confirm as we need the container logs which is currently blocked by #1836)

    点赞 评论 复制链接分享
  • weixin_39722188 weixin_39722188 4月前
    1. It will add 30 sec to each PR run
    2. It will add 2 minutes to a merge to master run

    I don't like the big sleep either, but it doesn't add that much to our development process and unless all those issues are getting fixed today, I really don't want to sit through another day of CI failures. I think this is a relatively easy and limited potential fix that has little cost and either improves things or costs us a small amount of time. And it is really easy to remove once we have the other fixes in place.

    点赞 评论 复制链接分享
  • weixin_39722188 weixin_39722188 4月前

    How about this: https://github.com/vmware/vic/pull/1869/commits/4e3c424a29761fb588b57c567c727c6297ba367e

    Poll govc?

    点赞 评论 复制链接分享
  • weixin_39659837 weixin_39659837 4月前

    -vmware where are we with this?

    点赞 评论 复制链接分享
  • weixin_39906878 weixin_39906878 4月前

    LGTM :sheep: :it:

    点赞 评论 复制链接分享

相关推荐