weixin_39599830
2020-12-28 06:02 阅读 0

JmDNS 3.5.0 still says it is 3.4.2

Hi,

thanks a lot for the release - that is really great news for us! Unfortunately I found a bug in it: The field VERSION in the Class JmDNS still contains 3.4.2 as the current version. Link to code

Best regards, Carsten

该提问来源于开源项目:jmdns/jmdns

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

8条回答 默认 最新

  • weixin_39850152 weixin_39850152 2020-12-28 06:02

    Thanks for noticing, this is nasty to have the version in the Java code itself... I'd actually suggest to remove it for future versions - for now we could set it to "3.x", what do you think?

    点赞 评论 复制链接分享
  • weixin_39599830 weixin_39599830 2020-12-28 06:02

    Actually, I'd prefer to have the real version reported - or none at all. 3.x does not proivde any informational valu, imho.

    Hope some more people chime in here ;)

    点赞 评论 复制链接分享
  • weixin_39850152 weixin_39850152 2020-12-28 06:02

    or none at all.

    Yes, but as it is a public field, removing it would break backward compatibility, that's why we have to keep the field in there (until a 4.x release).

    点赞 评论 复制链接分享
  • weixin_39599830 weixin_39599830 2020-12-28 06:02

    True, I forgot that aspect. Still, 3.x does feel weird..

    点赞 评论 复制链接分享
  • weixin_39608526 weixin_39608526 2020-12-28 06:02

    If you really need a correct version string for the 3 version, you could - setup maven to create a property file that contains the version(http://stackoverflow.com/a/2470071) - add this property file to the bundle - update the string value using the property file (but for non-osgi context this needs to be done in a static block)

    For 4.x it should be removed.

    You should perhaps create a tag with todos for the next major release or create a branch for that changes, so they get not lost.

    点赞 评论 复制链接分享
  • weixin_39850152 weixin_39850152 2020-12-28 06:02

    Ok, I tagged it. So what shall we do with the version until then? The property stuff is imho too complicated and not worth the effort. How about simply putting "3" as a version in there?

    点赞 评论 复制链接分享
  • weixin_39599830 weixin_39599830 2020-12-28 06:02

    I'd actually prefer to keep it around. I will give it a shot with the resource-file. We use that mechanism a lot here, so I don't think it will too hard....

    点赞 评论 复制链接分享
  • weixin_39599830 weixin_39599830 2020-12-28 06:02

    I'll close this one since it's been merged. Thanks!

    点赞 评论 复制链接分享