weixin_39633493
weixin_39633493
2020-12-28 14:55

Add Vaisala GLD360-reader.

Add a draft-version reader for Vaisala GLD360 (Global Lightning Detection) data.

  • [x] Tests added
  • [x] Tests passed
  • [x] Passes git diff origin/master -- "*py" | flake8 --diff
  • [x] Fully documented

该提问来源于开源项目:pytroll/satpy

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

8条回答

  • weixin_39629969 weixin_39629969 4月前

    Coverage Status

    Coverage increased (+0.05%) to 82.696% when pulling 793899d7b698491b591d799bc1982e86b6e09bfd on sjoro:gld360-reader into af826ff7a7989cb847015cd61b247c45ffd62fe3 on pytroll:master.

    点赞 评论 复制链接分享
  • weixin_39934613 weixin_39934613 4月前

    What's the status on this ? I the PR feature-complete ? do you plan to add tests ?

    点赞 评论 复制链接分享
  • weixin_39633493 weixin_39633493 4月前

    from my side it done for now. was thinking about possible test(s) for checking the sensitivity for the input format, but i'd like to get some brainstorming help with that.

    点赞 评论 复制链接分享
  • weixin_39934613 weixin_39934613 4月前

    Ok, we can talk about it next week.

    点赞 评论 复制链接分享
  • weixin_39633493 weixin_39633493 4月前

    Added a test for the file handler.

    点赞 评论 复制链接分享
  • weixin_39934613 weixin_39934613 4月前

    can you add this reader to the reader table in the index.rst file (in the doc) ?

    点赞 评论 复制链接分享
  • weixin_39945679 weixin_39945679 4月前

    Codecov Report

    Merging #687 into master will increase coverage by 0.04%. The diff coverage is 92.85%.

    Impacted file tree graph

    diff
    @@            Coverage Diff             @@
    ##           master     #687      +/-   ##
    ==========================================
    + Coverage   82.65%   82.69%   +0.04%     
    ==========================================
      Files         161      163       +2     
      Lines       23435    23491      +56     
    ==========================================
    + Hits        19370    19426      +56     
      Misses       4065     4065
    

    | Impacted Files | Coverage Δ | | |---|---|---| | satpy/tests/reader_tests/__init__.py | 98% <100%> (+0.04%) | :arrow_up: | | satpy/readers/vaisala_gld360.py | 90% <90%> (ø) | | | satpy/tests/reader_tests/test_vaisala_gld360.py | 96% <96%> (ø) | | | satpy/readers/__init__.py | 94.87% <0%> (+1.2%) | :arrow_up: |

    Continue to review full report at Codecov.

    Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af826ff...793899d. Read the comment docs.

    点赞 评论 复制链接分享
  • weixin_39633493 weixin_39633493 4月前

    Reader done with test data representing one full day, supported file type is flashes_20170620.txt. This is not the official file type from GLD360 network.

    点赞 评论 复制链接分享

相关推荐