weixin_39585795
weixin_39585795
2020-12-28 18:32

Update Monitoring Check validation to allow agent checks

Refactor validation and add tests to allow creation of agent-based monitoring checks

Closes #446

该提问来源于开源项目:pycontribs/pyrax

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

9条回答

  • weixin_39585795 weixin_39585795 4月前

    FWIW, I've tested this patch with Heat and I am able to create agent checks now. Is there a rough timeline for acceptance and/or release?

    点赞 评论 复制链接分享
  • weixin_39906114 weixin_39906114 4月前

    v1.9.3 was just released this past Friday. I cannot confirm release time frames for the next version at this time.

    点赞 评论 复制链接分享
  • weixin_39585795 weixin_39585795 4月前

    Thanks for the update . In the interim, we can do our builds with this patch included until its officially released.

    点赞 评论 复制链接分享
  • weixin_39906114 weixin_39906114 4月前

    Additionally, I will put this on my todo list over the next week or so to review.

    点赞 评论 复制链接分享
  • weixin_39585795 weixin_39585795 4月前

    Any updates on when this and #512 might be merged and/or released?

    点赞 评论 复制链接分享
  • weixin_39906114 weixin_39906114 4月前

    -randallburt Based on the conversation in #512 I am waiting on code from you that reproduces the error and validates the fix.

    Ideally, code that reproduces the error for this PR would be helpful too.

    点赞 评论 复制链接分享
  • weixin_39906114 weixin_39906114 4月前

    To clarify, I am unsure as to when I will have the availability to reproduce code that utilizes this change to validate it.

    The sooner I get code that reproduces the problem that this PR solves, the sooner I can get it merged.

    I am planning a 1.9.4 release soon, perhaps in early January, but I do not believe I would have the time to properly validate these changes without sample code by then. If you can get me sample code before then, it would be possible to include these PRs in that release.

    点赞 评论 复制链接分享
  • weixin_39585795 weixin_39585795 4月前

    Repro code: https://gist.github.com/rs-randallburt/f11e7649936c92a1e663

    点赞 评论 复制链接分享
  • weixin_39906114 weixin_39906114 4月前

    Merged, thanks!

    点赞 评论 复制链接分享

相关推荐