weixin_39926103
weixin_39926103
2020-12-28 22:29

Trinity long run Job

What was wrong?

Fixes #170

How was it fixed?

Now a new Circle CI job is created to run trinity --ropsten for 90 seconds.

Cute Animal Picture

put a cute animal picture link inside the parentheses

该提问来源于开源项目:ethereum/trinity

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

9条回答

  • weixin_39926103 weixin_39926103 4月前

    is there anyway where we could apply pytest parametrizations on functions which are imported but not explicitly defined at the place where we are applying pytest parametrization. (I searched quite a bit, but couldn't find anything). Something on the lines of

    
    from x import func
    
    .mark.parametrize(
        ...
    )
    func
    

    If we can't do it in the above way, then refactoring the code to a new function and using it won't be of any use.

    点赞 评论 复制链接分享
  • weixin_39934613 weixin_39934613 4月前

    It is tests that can be parametrised, not any function.

    What is needed here is two test_does_not_throw[,_long_run]() functions (tests), as you had them initially, but with the body of the test factored out (in the same file) - e.g. _run_does_not_throw(all, the, arguments, including, test, parametrisations).

    For existing CI jobs, test_does_not_throw_long_run() can be excluded in CI configuration explicitly.

    A new CI job needs to be added to run this test only.

    Another option is to have test_does_not_throw_long_run() in a separate file after all, being essentially a test declaration and a call to function body. This way, the regular integration CI job runs one file as currently, whereas a new CI job runs a different file - less muckery with existing jobs.

    (This is essentially what you went for in the beginning, except with the test body factored out into a separate function.)

    点赞 评论 复制链接分享
  • weixin_39926103 weixin_39926103 4月前

    could you do a preliminary review? If everything is fine, then I will create a Circle CI job.

    点赞 评论 复制链接分享
  • weixin_39926103 weixin_39926103 4月前

    me forgetting the await keyword before the run_command_and_detect_errors caused the lot of errors. I have fixed it and moved the async_process_runner to conftest.py. I am pretty confident that this is correct and hence moving on with the creation of the Circle CI job for this long run test.

    点赞 评论 复制链接分享
  • weixin_39926103 weixin_39926103 4月前

    I have created the Circle CI job as well. Please review it now. Thankyou.

    点赞 评论 复制链接分享
  • weixin_39926103 weixin_39926103 4月前

    done. Please take a look now. Thankyou.

    点赞 评论 复制链接分享
  • weixin_39593744 weixin_39593744 4月前

    Thanks! Merged :tada: :clap:

    点赞 评论 复制链接分享
  • weixin_39926103 weixin_39926103 4月前

    done, please review. Thankyou.

    点赞 评论 复制链接分享
  • weixin_39934613 weixin_39934613 4月前

    "How was it fixed?" section is now outdated.

    点赞 评论 复制链接分享

相关推荐