weixin_39632397
weixin_39632397
2020-12-29 01:35

Comments: FB comments into WP DB

Here is the first PR so comments via FB social plugin also show up, when FB comments are disabled. Next one will handle the 3 options and loading comment meta.

该提问来源于开源项目:facebookarchive/wordpress

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

9条回答

  • weixin_39640221 weixin_39640221 4月前
    • Might be an idea to squash all these commits. Will make life easier for reviewing.

    http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

    点赞 评论 复制链接分享
  • weixin_39587113 weixin_39587113 4月前

    Agreed-- can you squash? Also, can you merge this and https://github.com/facebook/wordpress/pull/221 ?

    点赞 评论 复制链接分享
  • weixin_39632397 weixin_39632397 4月前

    I think that PR can be dropped, since it's already part of this one.

    点赞 评论 复制链接分享
  • weixin_39632397 weixin_39632397 4月前

    The commit called "new branch for fb style comments" (5638b41) has all the changes that need to be reviewed. Ignore the ones after (they are not real changes).

    点赞 评论 复制链接分享
  • weixin_39587113 weixin_39587113 4月前

    Can we close https://github.com/facebook/wordpress/pull/221 then?

    点赞 评论 复制链接分享
  • weixin_39632397 weixin_39632397 4月前

    closed

    点赞 评论 复制链接分享
  • weixin_39837352 weixin_39837352 4月前

    Facebook Comments Box optionally supports third-party login providers (AOL, Yahoo, Hotmail). Sync'd comments with WordPress comments system would need to be able to save author data represented by these third-party login providers (name, email, URL) to properly attribute posts to their author.

    点赞 评论 复制链接分享
  • weixin_39850981 weixin_39850981 4月前

    +1

    Would be nice to have the correct number of comments show up in comments_popup_link

    点赞 评论 复制链接分享
  • weixin_39837352 weixin_39837352 4月前

    Comments Box provides a JS-focused solution with many filter overrides for current publishers. Closing the WordPress comment form approach.

    点赞 评论 复制链接分享

相关推荐