weixin_39841640
weixin_39841640
2020-12-29 17:48

Add CustomTool and Custom Tool Namespace property to the C# and VB file properties and property window

/project-system

Customer scenario

Users cannot use the Custom tool to generate associated code without the CustomTool in option in the Properties window

Bugs this fixes:

1136 and VSO

Workarounds, if any

Right-click C# items and go to property pages. That page has CustomTool textbox to provide the CustomTool

Risk

Low, since we are not modifying the behavior of existing component

Performance impact

More compilation time to run the generator

Is this a regression from a previous update?

No

Root cause analysis:

We are discovering these things to gain parity

How was the bug found?

Adhoc testing

该提问来源于开源项目:dotnet/project-system

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

10条回答

  • weixin_39841640 weixin_39841640 4月前

    I was able to test the properties window for C# and VB and Property pages for C#. Property pages for VB does not open. Will open an issue.

    Update: Opened #1329

    点赞 评论 复制链接分享
  • weixin_39841640 weixin_39841640 4月前

    /project-system made the Loc changes to the XAML files and updated the PR.

    An earlier PR #1318 missed the LOC step. Hence I am including it as part of this PR

    点赞 评论 复制链接分享
  • weixin_39632467 weixin_39632467 4月前

    for RTM approval. Without this users can't set SingleFileGenerators to generate, say, typescript definition files.

    点赞 评论 复制链接分享
  • weixin_39811166 weixin_39811166 4月前

    I have no familiarity with the custom tool, unfortunately. Can you help me understand the usage pattern/customer impact better, especially v.v. the workaround.

    点赞 评论 复制链接分享
  • weixin_39632467 weixin_39632467 4月前

    This PR is to add the two items in the properties pane for a file, so that users can specify a tool to be run for that file (which may in turn generate other files). image

    The workaround is to edit the project file and add the generator. The workaround mentioned in the template above (sorry I hadn't seen that before) is incorrect. There's a different bug that invoking properties on an item bring up the property pages instead of the property pane and those show things that it shouldn't show.

    点赞 评论 复制链接分享
  • weixin_39632467 weixin_39632467 4月前

    Also a comment about the size of this change- it's just adding these two properties to three rule files but for all localized languages - hence the large number of files.

    点赞 评论 复制链接分享
  • weixin_39811166 weixin_39811166 4月前

    My read is that this doesn't meet the RTW bar. However, could you bring this one up with JoC on tonight's call to confirm? We can always take it tomorrow if he wants this.

    点赞 评论 复制链接分享
  • weixin_39841640 weixin_39841640 4月前

    Merging since this PR has got the sign-offs and targeting the post-dev15 branch.

    点赞 评论 复制链接分享
  • weixin_39837607 weixin_39837607 4月前

    To get a better understanding of how this works, I'd recommend you watch the following videos on properties here:

    
    \\vspfs3\public\VSIDEPnT\CPS Brownbags\2013-05-30 CPS property system, part 1.mp4
    \\vspfs3\public\VSIDEPnT\CPS Brownbags\2013-06-20 CPS property system, part 2.mp4
    
    点赞 评论 复制链接分享
  • weixin_39841640 weixin_39841640 4月前

    Thanks. That was informative. That explains how the catalogs work.

    The videos were a long watch but good.

    点赞 评论 复制链接分享

相关推荐