weixin_39922683
weixin_39922683
2020-12-29 20:32

vcpkg install Shark

Not really an issue, but rather a suggestion which I will formulate as a wish:

I wish Shark could be installed via vcpkg.

该提问来源于开源项目:Shark-ML/Shark

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

11条回答

  • weixin_39963287 weixin_39963287 4月前

    Glad to see the interest in adding Shark to vcpkg!

    We'd love to have this library in vcpkg; all you need to do is create an appropriate ports/shark/ directory and make a PR! We enable users to download and build from source, so you don't need to generate any packages from your CMakeLists file. Anyone can add libraries, not just the authors :)

    Some useful resources for creating the port are our zlib example[1] doc and existing ports for other cmake projects[2].

    [1] https://github.com/Microsoft/vcpkg/blob/master/docs/examples/packaging-zlib.md [2] https://github.com/Microsoft/vcpkg/blob/master/ports/cpprestsdk/portfile.cmake

    点赞 评论 复制链接分享
  • weixin_39860849 weixin_39860849 4月前

    Thanks for the info. This looks easy enough. I will try to get a script working for the next release, which should only be a few weeks away.

    点赞 评论 复制链接分享
  • weixin_39860849 weixin_39860849 4月前

    Good news. I managed to finish most of the script-part of integration. Shark compiled using MSVC 19.14 and i managed to use the package in a test program. I also used the opportunity to remove most warnings and a small number of recently introduced compile errors.

    I am a bit worried about the "should run in visual studio 15" requirement I read in the vspkg doc. This might be...tough.

    点赞 评论 复制链接分享
  • weixin_39963287 weixin_39963287 4月前

    Don't worry about that too much; note that Visual Studio 15 actually means the latest release (Visual Studio 2017).

    点赞 评论 复制链接分享
  • weixin_39860849 weixin_39860849 4月前

    We happy take pull requests that update the CMakeLists.txt to incorporate vspkg package generation

    点赞 评论 复制链接分享
  • weixin_39922683 weixin_39922683 4月前

    Following the Contribution Guidelines somebody will need to complete a Contributor License Agreement (CLA) before the pull request can be accepted.

    点赞 评论 复制链接分享
  • weixin_39860849 weixin_39860849 4月前

    This is only needed for contributing to vcpkg(i.e. giving them your code). We are Shark, so no need to do that for us, except that you have to understand that everything we pull from you is going to be licensed under the LGPL as the rest of shark.

    点赞 评论 复制链接分享
  • weixin_39860849 weixin_39860849 4月前

    Ah now i see. this is needed for adding the shark-vspkg into the official package list. We can do that once we know what to do and once the generation of those packages work.

    点赞 评论 复制链接分享
  • weixin_39922683 weixin_39922683 4月前

    From the Contribution Guidelines:

    In order to avoid wasting your time, we highly encourage opening an issue to discuss whether the pull request you're thinking about making will be acceptable. This is doubly true for features and new packages.

    Would you be interested in opening an issue there? I am afraid I am not qualified to discuss about the nuts and bolts of Shark should it get there.

    点赞 评论 复制链接分享
  • weixin_39860849 weixin_39860849 4月前

    yeah, we can do that. But am i correct that it is already majorly hapeful if we can generate those packages our CMakeLists.txt so that you can install shark via package manager?

    点赞 评论 复制链接分享
  • weixin_39621870 weixin_39621870 4月前

    Or a nuGet? I initially thought this was reserved to C#, but there are actually plenty of C++ packages there.

    点赞 评论 复制链接分享

相关推荐