weixin_39964573
2020-12-30 06:45 阅读 0

Cloudstack support

This PR adds cloudstack support.

该提问来源于开源项目:chef/ohai

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

11条回答 默认 最新

  • weixin_39640845 weixin_39640845 2020-12-30 06:45

    Hi. Your friendly Curry bot here. Just letting you know that there are commit authors in this Pull Request who appear to not have signed a Chef CLA.

    The following GitHub users do not appear to have signed a CLA:

    Please sign the CLA here.

    点赞 评论 复制链接分享
  • weixin_39964573 weixin_39964573 2020-12-30 06:45

    Signed.

    点赞 评论 复制链接分享
  • weixin_39964573 weixin_39964573 2020-12-30 06:45

    I'll make sure we skip the bind part in the tests. Will re-send.

    点赞 评论 复制链接分享
  • weixin_39964573 weixin_39964573 2020-12-30 06:45

    We are currently failing on ruby 1.8.7 due to a missing exception. If this is important to fix i'll do it.

    点赞 评论 复制链接分享
  • weixin_39964573 weixin_39964573 2020-12-30 06:45

    Fixed the ruby 1.8.7 issue.

    点赞 评论 复制链接分享
  • weixin_39623411 weixin_39623411 2020-12-30 06:45

    LGTM

    点赞 评论 复制链接分享
  • weixin_39964573 weixin_39964573 2020-12-30 06:45

    Fixed the mentioned issues.

    点赞 评论 复制链接分享
  • weixin_39964573 weixin_39964573 2020-12-30 06:45

    Hmm, the hint? function doesn't seem to be included there. :(

    Will see what i can find.

    点赞 评论 复制链接分享
  • weixin_39964573 weixin_39964573 2020-12-30 06:45

    Using the Ohai::Hints.hint?() instead of the dsl in the mixin.

    点赞 评论 复制链接分享
  • weixin_39964573 weixin_39964573 2020-12-30 06:45

    do i need to do anything else to get this merged?

    点赞 评论 复制链接分享
  • weixin_39633054 weixin_39633054 2020-12-30 06:45

    nope, it's labeled "Ready for Merge" so it's just waiting for a committer to make a merge pass on Ohai.

    点赞 评论 复制链接分享

相关推荐