weixin_39903176
weixin_39903176
2021-01-06 13:38

Decouple TR_PrexArgInfo from TR_InlinerTracer

I originally submitted these changes in #8419. However, I have made modifications so that this PR does not need to be merged at the same time as a PR in OMR.

This PR in OMR must be merged first: https://github.com/eclipse/omr/pull/4903

  • Replace calls to TR_InlinerTracer::dumpPrexArgInfo with calls to TR_PrexArgInfo::dumpTrace.
  • This will allow the method dumpPrexArgInfo to be removed from OMR.

  • Prepare TR_PrexArgInfo methods to be changed to have parameters of type TR_LogTracer instead of TR_InlinerTracer.

  • This is done by using the macro TR_PREXARGINFO_TRACER_CLASS which will later be updated in OMR.
  • Since TR_LogTracer is a less specialized class than TR_InlinerTracer, this should make the TR_PrexArgInfo class more reusable.

  • Similar modifications to TR_InterpreterEmulator and TR_J9InlinerUtil.

See: #7936

Signed-off-by: Ryan Shukla

该提问来源于开源项目:eclipse/openj9

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

5条回答

  • weixin_39903176 weixin_39903176 4月前

    whenever you get a chance could you take a look at these changes again? I made some changes since the last PR as per your comments here: https://github.com/eclipse/openj9/pull/8419#discussion_r372110800

    点赞 评论 复制链接分享
  • weixin_39818662 weixin_39818662 4月前

    LGTM

    点赞 评论 复制链接分享
  • weixin_39903176 weixin_39903176 4月前

    could you take a look at this PR since you merged this one: https://github.com/eclipse/omr/pull/4903?

    The travis build failed because I opened this PR before the omr one had been merged.

    点赞 评论 复制链接分享
  • weixin_39926311 weixin_39926311 4月前

    Jenkins test sanity all jdk8

    点赞 评论 复制链接分享
  • weixin_39903176 weixin_39903176 4月前

    The failing build looks unrelated

    点赞 评论 复制链接分享

相关推荐