weixin_39854326
weixin_39854326
2021-01-08 08:17

Reset password token test fix

No need reload resource after update.

该提问来源于开源项目:lynndylanhurley/devise_token_auth

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

7条回答

  • weixin_39991926 weixin_39991926 4月前

    this seems like a really small change - can you explain its impact?

    点赞 评论 复制链接分享
  • weixin_39854326 weixin_39854326 4月前

    It impacts test performance.

    点赞 评论 复制链接分享
  • weixin_39991926 weixin_39991926 4月前

    Sure! If or approve of this change I'm down to merge then.

    点赞 评论 复制链接分享
  • weixin_39613385 weixin_39613385 4月前

    For some reason was added in test, but if you think it can improve the test performance, we can merge it, but can you squash the commits?

    点赞 评论 复制链接分享
  • weixin_39991926 weixin_39991926 4月前

    for future reference we can actually auto-squash when we merge?

    点赞 评论 复制链接分享
  • weixin_39991926 weixin_39991926 4月前

    https://github.com/blog/2141-squash-your-commits

    点赞 评论 复制链接分享
  • weixin_39613385 weixin_39613385 4月前

    Yeah, you will lose the merge commit but it works

    点赞 评论 复制链接分享

相关推荐