weixin_40004212
weixin_40004212
2021-01-08 16:32

Refactoring of and function in ValidationResult class

This function didnt have terminating short circuit which is important for and operator functions.

Also this function gets called multiple times since it's validation function. hence improving needed here.

After verifying usages, left out following two classes 1. PercentageNumberValidator - since it's using only two validation 2. PhoneNumberValidator - have variable inputs and this is only place.

该提问来源于开源项目:bisq-network/bisq

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

4条回答

  • weixin_39542514 weixin_39542514 4月前

    Could you please resolve the conflict? Thanks!

    点赞 评论 复制链接分享
  • weixin_39542514 weixin_39542514 4月前

    I activated yesterday codacy's PR Quality Review for the Bisq repository. It found for your PR a couple of issues which you can view in the Details link next to the PR check. Please review and push fixes for this issues to trigger a re-review by codacy. Thanks!

    点赞 评论 复制链接分享
  • weixin_40004212 weixin_40004212 4月前

    Have removed unused and its passing now. pls review.

    点赞 评论 复制链接分享
  • weixin_39542514 weixin_39542514 4月前

    Please make sure that you are applying our format style properly (see my commit https://github.com/bisq-network/bisq/pull/3838/commits/a9bbbdf54566afd623e77ecf348af65e036f16b7). I pushed it this time to save more review time on this, but will reject it in the next PR.

    点赞 评论 复制链接分享

相关推荐