weixin_39562615
weixin_39562615
2021-01-08 23:36

Fix race condition

Fix race condition on assignment of imports to unsafe parserConfiguration field.

DROOLS-1359

该提问来源于开源项目:kiegroup/drools

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

4条回答

  • weixin_39564187 weixin_39564187 4月前

    Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

    点赞 评论 复制链接分享
  • weixin_39993301 weixin_39993301 4月前

    I looked at this PR, and while it makes a point on a concurrency issue, I don't think the fix by itself is enough. It seems to me that the whole MVELDialectRuntimeData class is thread unsafe. So the first question is: does it need to be thread-safe? and if so, then we need a lot more done there, including synchronization of critical areas. Can you please take a look?

    -1 to this PR as it is insufficient as is, but it does demonstrate one of things in this class that is not thread safe.

    点赞 评论 复制链接分享
  • weixin_39924198 weixin_39924198 4月前

    I also don't see why the MVELDialectRuntimeData should be thread-safe at the moment and if this is true this fix is far from being enough.

    If you have the evidence of a race condition caused the MVELDialectRuntimeData please send a test case demonstrating it.

    点赞 评论 复制链接分享
  • weixin_39564187 weixin_39564187 4月前

    Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

    点赞 评论 复制链接分享

相关推荐