weixin_39635459
weixin_39635459
2021-01-09 01:33

Revert "Temporary fix to avoid logcontrol file grow without limits"

I guess we can remove this workaround now

该提问来源于开源项目:vespa-engine/vespa

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

7条回答

  • weixin_39635459 weixin_39635459 4月前

    Yes, you are right, the way we create the logger name requires cleanup of logcontrol files

    点赞 评论 复制链接分享
  • weixin_39769740 weixin_39769740 4月前

    close or merge?

    点赞 评论 复制链接分享
  • weixin_39635459 weixin_39635459 4月前

    This is ticket https://jira.corp.yahoo.com/browse/VESPA-7317, haven't gotten around to that one yet so I don't know. Agree that PRs like this shouldn't be left like this, but that's how things are right now.

    点赞 评论 复制链接分享
  • weixin_39635459 weixin_39635459 4月前

    Logcontrol files are cleaned now, please review

    点赞 评论 复制链接分享
  • weixin_39799565 weixin_39799565 4月前

    👍

    点赞 评论 复制链接分享
  • weixin_39799565 weixin_39799565 4月前

    merge at will.

    点赞 评论 复制链接分享
  • weixin_39799565 weixin_39799565 4月前

    Is this not needed until we clean up old logcontrol files ?

    点赞 评论 复制链接分享

相关推荐