weixin_39799565
weixin_39799565
2021-01-09 02:11

handling for permissions fail on well-known file

one of our customers has an edge case where sometimes they get an inexplicable permissions error on the well-known file. It's a GCE instance, so it should use the 4th method (line 106+). It never reaches this code as method 2 fails with a permissions error on line 92.

该提问来源于开源项目:golang/oauth2

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

6条回答

  • weixin_39768388 weixin_39768388 4月前

    This PR (HEAD: fb9943c1e057428d5fa17c4e1288f118d3446398) has been imported to Gerrit for code review.

    Please visit https://go-review.googlesource.com/c/oauth2/+/158737 to see it.

    Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

    点赞 评论 复制链接分享
  • weixin_39768388 weixin_39768388 4月前

    Message from Gobot Gobot:

    Patch Set 1:

    Congratulations on opening your first change. Thank you for your contribution!

    Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

    Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

    During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.

    Please don’t reply on this GitHub thread. Visit golang.org/cl/158737. After addressing review feedback, remember to publish your drafts!

    点赞 评论 复制链接分享
  • weixin_39768388 weixin_39768388 4月前

    Message from Brad Fitzpatrick:

    Patch Set 1:

    Why "sometimes"? Seems like if it failed it'd always get the permission error (in which case you can fix the permissions?).

    I'd like to understand this bug before trying to fix it. I'm afraid this fix would lead to people losing useful error messages about things that are wrong that shouldn't be.

    Please don’t reply on this GitHub thread. Visit golang.org/cl/158737. After addressing review feedback, remember to publish your drafts!

    点赞 评论 复制链接分享
  • weixin_39799565 weixin_39799565 4月前

    Issue with this specific customer turns out to be due to SELinux policy.

    It did indeed only fail sometimes, but once it started failing it kept failing until the VM was rebooted.

    I think we can cancel this PR

    On Wed, Feb 13, 2019 at 12:13 AM GopherBot wrote:

    Message from Brad Fitzpatrick:

    Patch Set 1:

    Why "sometimes"? Seems like if it failed it'd always get the permission error (in which case you can fix the permissions?).

    I'd like to understand this bug before trying to fix it. I'm afraid this fix would lead to people losing useful error messages about things that are wrong that shouldn't be.

    Please don’t reply on this GitHub thread. Visit golang.org/cl/158737 https://go-review.googlesource.com/c/oauth2/+/158737#message-9aebe84a2f57a13ab4d79bb31f6c550ab36be548 . After addressing review feedback, remember to publish your drafts https://github.com/golang/go/wiki/GerritBot#i-left-a-reply-to-a-comment-in-gerrit-but-no-one-but-me-can-see-it !

    — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/golang/oauth2/pull/366#issuecomment-462979061, or mute the thread https://github.com/notifications/unsubscribe-auth/AcqBmMaGbE6T47YBxOLD4iOpWdM9mLJyks5vM0qTgaJpZM4aKiCV .

    --

    Edo Akse | Platform SME | eakse.com | Sellbytel BCN

    点赞 评论 复制链接分享
  • weixin_39768388 weixin_39768388 4月前

    Message from Brady Pratt:

    Patch Set 1:

    It seems like this can be closed per request of author's bug not related to "handling for permissions fail on well-known file" rather a policy issue on their side. (https://github.com/golang/oauth2/pull/366#issuecomment-463116443)

    Please don’t reply on this GitHub thread. Visit golang.org/cl/158737. After addressing review feedback, remember to publish your drafts!

    点赞 评论 复制链接分享
  • weixin_39768388 weixin_39768388 4月前

    Message from Go Bot:

    Patch Set 1:

    Congratulations on opening your first change. Thank you for your contribution!

    Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

    Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

    During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.

    Please don’t reply on this GitHub thread. Visit golang.org/cl/158737. After addressing review feedback, remember to publish your drafts!

    点赞 评论 复制链接分享

相关推荐