weixin_39855944
weixin_39855944
2021-01-09 04:42

Let nscert's wildcard certs create secret with domain name instead of the name of namespace

Proposed Changes

Currently wildcard creates secret with the name of its namespace. This causes error when the secret name is duplicated with other secret name. In fact, it always fails when domain name is changed.

This patch changes wildcard cert to create secret name with domain name.

/lint

Fixes https://github.com/knative/serving/issues/5538

Release Note

release-note
NONE

/cc

该提问来源于开源项目:knative/serving

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

8条回答

  • weixin_39702335 weixin_39702335 4月前

    : GitHub didn't allow me to request PR reviews from the following users: rmoe.

    Note that only knative members and repo collaborators can review this PR, and authors cannot review their own PRs.

    In response to [this](https://github.com/knative/serving/pull/5539): >## Proposed Changes > >Currently wildcard creates secret with the name of its namespace. This >causes error when the secret name is duplicated with other secret >name. In fact, it always fails when domain name is changed. > >This patch changes wildcard cert to create secret name with domain >name. > >/lint > >Fixes https://github.com/knative/serving/issues/5538 > >**Release Note** > >
    release-note
    >NONE
    >
    > >/cc > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
    点赞 评论 复制链接分享
  • weixin_39598954 weixin_39598954 4月前

    I think we should still name the secret something besides the namespace name and using the same name as the cert makes sense.

    点赞 评论 复制链接分享
  • weixin_39855944 weixin_39855944 4月前

    Would you mind taking a look at this?

    点赞 评论 复制链接分享
  • weixin_39729837 weixin_39729837 4月前

    /lgtm

    点赞 评论 复制链接分享
  • weixin_39855944 weixin_39855944 4月前

    /assign

    点赞 评论 复制链接分享
  • weixin_39942397 weixin_39942397 4月前

    /approve

    点赞 评论 复制链接分享
  • weixin_39702335 weixin_39702335 4月前

    [APPROVALNOTIFIER] This PR is APPROVED

    This pull-request has been approved by: nak3, tcnghia

    The full list of commands accepted by this bot can be found here.

    The pull request process is described here

    Needs approval from an approver in each of these files: - ~~[pkg/reconciler/OWNERS](https://github.com/knative/serving/blob/master/pkg/reconciler/OWNERS)~~ [tcnghia] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
    点赞 评论 复制链接分享
  • weixin_39817391 weixin_39817391 4月前

    The following jobs failed:

    Test name | Triggers | Retries --- | --- | --- pull-knative-serving-unit-tests | pull-knative-serving-unit-tests | 1/3

    Automatically retrying due to test flakiness... /test pull-knative-serving-unit-tests

    点赞 评论 复制链接分享

相关推荐