I splited two obvious errors into separate PRs https://github.com/jruby/ruby/pull/2 https://github.com/jruby/ruby/pull/3
fixes https://github.com/jruby/jruby/issues/5956 and https://github.com/jruby/jruby/issues/5955
but this test case doesn't work yet https://github.com/jruby/jruby/blob/4e8bb2666a7257f0f5986800f96bb88efdd6acbd/test/mri/fiddle/test_func.rb#L73 I'm experimanting for now :)
- 点赞 评论 复制链接分享
one more interesting failure https://github.com/jruby/jruby/blob/4e8bb2666a7257f0f5986800f96bb88efdd6acbd/test/mri/fiddle/test_func.rb#L44
a string pointer #to_s should return a ruby string. That would be tricky to implement :)点赞 评论 复制链接分享
Do you think there's any work remaining here or could we go ahead with a merge?点赞 评论 复制链接分享
I have merged jruby/ruby#2 and jruby/ruby#3 across the two active branches
jruby-ruby_2_6_5and incorporated their changes into the JRuby branches
I also figured out why the libc changes keeps disappearing: we were versioning
lib/ruby/stdlib/fiddle/jruby.rbin both places when it's specific to JRuby, without any equivalent in CRuby, and subject to frequent updates. I modified all branches to reflect this, with messages about the proper versioning location added to jruby here and here.
(I see the spelling error now and will fix that).
I've also made sure that all changes from jruby/ruby's
masterbranch have been incorporated back into the jruby/ruby
jruby-ruby_2_6_5branch upon which the jruby/jruby
ruby-2.6branch is based. See jruby/ruby.
We need a better way to manage our patch set against CRuby's stdlib.点赞 评论 复制链接分享
Do you think there's any work remaining here or could we go ahead with a merge?
there're still many broken parts, but I think it's ready for review点赞 评论 复制链接分享
Everything here seems appropriate to me. I will merge and we can do other fixes in other PRs.点赞 评论 复制链接分享
Nice! We definitely want to get Fiddle working better. Long term it might make more sense to do a direct implementation atop jnr-ffi, but for now getting the FFI version working is probably best.点赞 评论 复制链接分享