weixin_39768371
weixin_39768371
2021-01-09 12:22

Merge feature-hal-spec-sleep to master

Description

New HAL Sleep API.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

该提问来源于开源项目:ARMmbed/mbed-os

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

12条回答

  • weixin_39824898 weixin_39824898 4月前

    Marking as DNM since this will be coming in a larger PR.

    点赞 评论 复制链接分享
  • weixin_39824898 weixin_39824898 4月前

    Removed labeling to make 5.9 tags easier to sort through. Will be brought in with https://github.com/ARMmbed/mbed-os/pull/7009.

    点赞 评论 复制链接分享
  • weixin_39768371 weixin_39768371 4月前

    First one is ready for testing.

    点赞 评论 复制链接分享
  • weixin_39824898 weixin_39824898 4月前

    Cool. Will take a quick look at it whilst Travis CI does it thing.

    点赞 评论 复制链接分享
  • weixin_39824898 weixin_39824898 4月前

    Is this PR just the feature branch coming into master, or are there other PRs in her as well?

    点赞 评论 复制链接分享
  • weixin_39768371 weixin_39768371 4月前

    It's feature branch, but it has some of the partners code that wasn't validated by the CI.

    点赞 评论 复制链接分享
  • weixin_39824898 weixin_39824898 4月前

    Alrgiht. I saw the auto-merges close those PRs. Was hoping that this method wouldn't do that, but oh well.

    From the PoV of master, the effect is the same. The changes are still gated by CI.

    FYI /mbed-os-maintainers

    点赞 评论 复制链接分享
  • weixin_39946355 tomorrow-77 4月前

    I would like to draw to your attention one significant issue with the current deep sleep specification - the console. If using a "proper" buffered console - like UARTSerial, deep sleep is rendered non-functional, as we must lock deep sleep to get serial IRQs. This is quite unfortunate as we're encouraging and setting apps to use buffered serial (it's an absolute requirement for some), thus reducing the number of apps that can deep sleep.

    I think we may need some sort of mechanism to flag "extra devices that work in deep sleep on this platform".

    Shall this be captured in Serial specs work to capture it there ?

    The flag - this comes from time to time, targets hooks to overwrite the default locking or similar approach to have this "sort of mechanism to flag"

    点赞 评论 复制链接分享
  • weixin_39731807 weixin_39731807 4月前

    Shall this be captured in Serial specs work to capture it there ?

    I think we do need to tackle it from two ends, basically independently

    • a general HAL mechanism for letting targets declare that extra devices beyond the minimum do work in deep sleep.

    • something in UARTSerial+retargetting to allow write-only opening to avoid locking deep sleep for unwanted RX on platforms without the above extension.

    So I think that goes to "general HAL" and "serial/stream C++/retarget layers", not necessarily anything for the "serial HAL" specifically. But perhaps a general mechanism could be done as part of the serial HAL package.

    Still a bit stuck with greentea, but the latter mechanism could maybe be runtime switchable - we effectively close serial input while doing the deep sleep tests, then reopen.

    点赞 评论 复制链接分享
  • weixin_39946355 tomorrow-77 4月前

    /morph build

    点赞 评论 复制链接分享
  • weixin_39946355 tomorrow-77 4月前

    Will retrigger the build once emac lands (might cause some conflicts), the current build aborted. This shoud happen shortly 🤞

    点赞 评论 复制链接分享
  • weixin_39734048 weixin_39734048 4月前

    Build : FAILURE

    Build number : 2138 Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6994/

    点赞 评论 复制链接分享

相关推荐