weixin_39638929
2021-01-12 02:42 阅读 0

Add complex dtype to sparse matrix

This PR add complex64 and complex128 dtype to sparse matrix module. Complex dtype cuda functions equivalent to current float dtype are also imported.

该提问来源于开源项目:cupy/cupy

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

5条回答 默认 最新

  • weixin_39581896 weixin_39581896 2021-01-12 02:42

    This fix looks good, but there is no test. You need to fix test codes such as test_csr.py https://github.com/cupy/cupy/blob/master/tests/cupy_tests/sparse_tests/test_csr.py It now only tests float32 and float64. Please add complex64 and complex128, and change values of arrays in the tests to use complex numbers.

    点赞 评论 复制链接分享
  • weixin_39638929 weixin_39638929 2021-01-12 02:42

    Maybe someone can help me with the tests, I am not very familiar with the test system and it looks like really complicated.

    点赞 评论 复制链接分享
  • weixin_39581896 weixin_39581896 2021-01-12 02:42

    OK, can I take over this PR? I'll try to make a test for this fix.

    点赞 评论 复制链接分享
  • weixin_39638929 weixin_39638929 2021-01-12 02:42

    Yes, you can. Keep up the good work!

    点赞 评论 复制链接分享
  • weixin_39581896 weixin_39581896 2021-01-12 02:42

    This PR is merged to #1277. Thank you very much!

    点赞 评论 复制链接分享

相关推荐