weixin_39806065
2021-01-12 13:17 阅读 0

r/aws_securityhub: Add aws_securityhub_member resource

Partly addresses #6674

Changes proposed in this pull request:

  • New Resource: aws_securityhub_member

Output from acceptance testing:


$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSecurityHub'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSecurityHub -timeout 120m
=== RUN   TestAccAWSSecurityHub
=== RUN   TestAccAWSSecurityHub/Account
=== RUN   TestAccAWSSecurityHub/Account/basic
=== RUN   TestAccAWSSecurityHub/Member
=== RUN   TestAccAWSSecurityHub/Member/invite
=== RUN   TestAccAWSSecurityHub/Member/basic
=== RUN   TestAccAWSSecurityHub/ProductSubscription
=== RUN   TestAccAWSSecurityHub/ProductSubscription/basic
=== RUN   TestAccAWSSecurityHub/StandardsSubscription
=== RUN   TestAccAWSSecurityHub/StandardsSubscription/basic
--- PASS: TestAccAWSSecurityHub (185.81s)
    --- PASS: TestAccAWSSecurityHub/Account (27.28s)
        --- PASS: TestAccAWSSecurityHub/Account/basic (27.28s)
    --- PASS: TestAccAWSSecurityHub/Member (70.77s)
        --- PASS: TestAccAWSSecurityHub/Member/invite (46.90s)
        --- PASS: TestAccAWSSecurityHub/Member/basic (23.87s)
    --- PASS: TestAccAWSSecurityHub/ProductSubscription (51.00s)
        --- PASS: TestAccAWSSecurityHub/ProductSubscription/basic (51.00s)
    --- PASS: TestAccAWSSecurityHub/StandardsSubscription (36.75s)
        --- PASS: TestAccAWSSecurityHub/StandardsSubscription/basic (36.75s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws   185.852s

该提问来源于开源项目:hashicorp/terraform-provider-aws

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

12条回答 默认 最新

  • weixin_39806065 weixin_39806065 2021-01-12 13:17

    Actually, I'll probably tweak this to include better error information once https://github.com/aws/aws-sdk-go/issues/2372 is resolved

    点赞 评论 复制链接分享
  • weixin_39931146 weixin_39931146 2021-01-12 13:17

    Looks like this needs to be rebased.

    点赞 评论 复制链接分享
  • weixin_39571403 weixin_39571403 2021-01-12 13:17

    This has been open for a while. What will it take to get this merged in?

    点赞 评论 复制链接分享
  • weixin_39571403 weixin_39571403 2021-01-12 13:17

    ^^

    点赞 评论 复制链接分享
  • weixin_39806065 weixin_39806065 2021-01-12 13:17

    Rebased and should be up to date now

    点赞 评论 复制链接分享
  • weixin_39900736 weixin_39900736 2021-01-12 13:17

    What is the status on this PR? Really looking forward to this feature along with a corresponding acceptor.

    点赞 评论 复制链接分享
  • weixin_39694264 weixin_39694264 2021-01-12 13:17

    I'm also waiting for this one. What does it take to get this merged?

    点赞 评论 复制链接分享
  • weixin_39900736 weixin_39900736 2021-01-12 13:17

    What work still needs to be done for this PR to be accepted?

    点赞 评论 复制链接分享
  • weixin_39884144 weixin_39884144 2021-01-12 13:17

    look like all require work is done, Can this be merged? LGTM.

    点赞 评论 复制链接分享
  • weixin_39654245 weixin_39654245 2021-01-12 13:17

    Patiently waiting for this feature to be merged as well :-)

    点赞 评论 复制链接分享
  • weixin_39717598 weixin_39717598 2021-01-12 13:17

    This has been released in version 2.54.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

    For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

    点赞 评论 复制链接分享
  • weixin_39717598 weixin_39717598 2021-01-12 13:17

    I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

    If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

    点赞 评论 复制链接分享

相关推荐