2021-01-12 17:35 阅读 0

resource/aws_redshift_cluster: Send correct values when resizing

When resizing a Redshift cluster, the AWS API is expecting the Cluster Type, Node Type, and Number of Nodes regardless of which value changed. If not passed it will error out with [WARN] Error modifying Redshift Cluster (navistone-public-cluster): InvalidParameterCombination: Number of nodes for cluster type multi-node must be greater than or equal to 2

Now we send all values if any one of them change. Closes #484

Signed-off-by: Ken Herner


  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享

7条回答 默认 最新

  • weixin_39589253 weixin_39589253 2021-01-12 17:35

    Fixed the test cases, thanks for pointing that out.

    点赞 评论 复制链接分享
  • weixin_39950552 weixin_39950552 2021-01-12 17:35

    Hmm, I'm getting this strange error when running the acceptance testing now. I will try to look into it later today if I have time.

    === RUN   TestAccAWSRedshiftCluster_updateNodeType
    --- FAIL: TestAccAWSRedshiftCluster_updateNodeType (773.13s)
        testing.go:513: Step 1 error: Error applying: 1 error(s) occurred:
            * aws_redshift_cluster.default: 1 error(s) occurred:
            * aws_redshift_cluster.default: [WARN] Error modifying Redshift Cluster (tf-redshift-cluster-2884899450099823142): InvalidParameterCombination: Single-node with dw2.8xlarge is not supported
                status code: 400, request id: c4b7f272-0542-11e8-85c9-afeaf0a03f38
    点赞 评论 复制链接分享
  • weixin_39804631 weixin_39804631 2021-01-12 17:35

    My team is hitting this now, FYI, thanks for the effort.

    点赞 评论 复制链接分享
  • weixin_39924573 weixin_39924573 2021-01-12 17:35

    +1 just encountered this. Anything pending to merge this fix, ?

    点赞 评论 复制链接分享
  • weixin_39589253 weixin_39589253 2021-01-12 17:35

    I should have fixed the acceptance test issue with the node type now, could you retest acceptance? Thanks!

    点赞 评论 复制链接分享
  • weixin_39950552 weixin_39950552 2021-01-12 17:35

    This has been released in version 1.18.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

    点赞 评论 复制链接分享
  • weixin_39717598 weixin_39717598 2021-01-12 17:35

    I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

    If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

    点赞 评论 复制链接分享