weixin_39886841
weixin_39886841
2021-01-12 18:14

CONTRIBUTING.mdown

Thanks for proposing a pull request!

To help us review the request, please complete the following:

  • [x] sign contributor license agreement
  • [x] I've ensured that all existing tests pass and added tests (when/where necessary)
  • [x] I've updated the documentation (when/where necessary) and Changelog (when/where necessary)
  • [x] I've added the proper label to this pull request (e.g. bug for bug fixes)

Pull Request Details

Describe what you accomplished in this pull request (for example, what happens before the change, and after the change)

Test Plan

Test Plan: Add your test plan here

该提问来源于开源项目:facebook/facebook-android-sdk

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

8条回答

  • weixin_39550258 weixin_39550258 4月前

    Hi Mohd4633! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

    If you have received this in error or have any questions, please contact us at cla.com. Thanks!

    点赞 评论 复制链接分享
  • weixin_39550258 weixin_39550258 4月前

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

    点赞 评论 复制链接分享
  • weixin_39886841 weixin_39886841 4月前

    660

    点赞 评论 复制链接分享
  • weixin_39886841 weixin_39886841 4月前

    660 Facebook open source project.

    点赞 评论 复制链接分享
  • weixin_39550258 weixin_39550258 4月前

    Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

    点赞 评论 复制链接分享
  • weixin_39902598 weixin_39902598 4月前

    Any reason why the file was renamed from CONTRIBUTING.mdown to CONTRIBUTING.mdowna?

    If anything, it should probably renamed to the default CONTRIBUTING.md..

    cc for additional info on the mdown extension (b0429e5984e68e371610e007633a119b75b45ff4)

    点赞 评论 复制链接分享
  • weixin_39688451 weixin_39688451 4月前

    sorry I don't remember what motivated the change to .mdown here at the time, but agreed that .md would be better at this point. Also, perhaps GitHub is not showing me a correct view of this PR, but the change contents also look incorrect.

    点赞 评论 复制链接分享
  • weixin_39646018 weixin_39646018 4月前

    Closing this PR since the proposed changes (https://github.com/facebook/facebook-android-sdk/pull/660/files) don't look correct.

    点赞 评论 复制链接分享

相关推荐