weixin_39886841
weixin_39886841
2021-01-12 19:29

Adding a minimal implementation of std::optional.

We're using C++11, which doesn't have std::optional. We need a few features of std::optional for improved GPS support. These are implemented here.

该提问来源于开源项目:cartographer-project/cartographer

  • 点赞
  • 写回答
  • 关注问题
  • 收藏
  • 复制链接分享
  • 邀请回答

8条回答

  • weixin_39600319 weixin_39600319 4月前

    Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

    :memo: Please visit https://cla.developers.google.com/ to sign.

    Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

    • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
    • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
    • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.
    点赞 评论 复制链接分享
  • weixin_39886841 weixin_39886841 4月前

    I signed it!

    点赞 评论 复制链接分享
  • weixin_39866867 weixin_39866867 4月前

    ping?

    点赞 评论 复制链接分享
  • weixin_39526185 weixin_39526185 4月前

    We checked the Google CLA database and Github user spielawa has not signed the CLA yet. Can you double check that you actually specified the right email address when signing?

    点赞 评论 复制链接分享
  • weixin_39886841 weixin_39886841 4月前

    I signed it!

    点赞 评论 复制链接分享
  • weixin_39600319 weixin_39600319 4月前

    CLAs look good, thanks!

    点赞 评论 复制链接分享
  • weixin_39627405 weixin_39627405 4月前

    -the-cartographer merge

    点赞 评论 复制链接分享
  • weixin_39557402 weixin_39557402 4月前

    Merge requested by authorized user wohe. Merge queue now has a length of 1.

    点赞 评论 复制链接分享