问题遇到的现象和发生背景
同事写出这样的代码，我非常不理解，并且无法改变对方，我应该离职嘛
@Slf4j
@RestController
@RequestMapping("/sysArea")
@Api(tags = {"区域管理"})
public class SysAreaController extends CommonController {
@Autowired
private SysAreaService sysAreaService;
/**
* 查询单条记录
* @param id
* @return ApiResult
*/
@PostMapping("get/{id}")
@ApiOperation(value="通过主键查询", notes="通过主键查询", response = SysArea.class)
@ApiImplicitParams({@ApiImplicitParam(name = "id", value = "主键id", required = true)})
public ApiResult get(@PathVariable("id") Long id) {
try {
return sysAreaService.get(id);
} catch (Exception e) {
log.error(e.getMessage(), e);
}
return ApiResult.error(ResultStatus.error.getCode(), MsgConstant.INQUIRE_FAILURE.getMsg());
}
/**
* 保存
* @param json
* @return ApiResult
*/
@PostMapping("save")
@ApiOperation(value="保存", notes="保存", response = SysArea.class)
@ApiImplicitParam(name = "json", value = "{\"startRow\":0,\"parameter\":{\"id\":\"\",\"name\":\"简名\",\"fullName\":\"全名\",\"cIdx\":\"\",\"parentId\":\"上级id\",\"createBy\":\"创建人\",\"createTime\":\"创建时间\",\"updateBy\":\"修改人\",\"updateTime\":\"修改时间\",\"deleteFlag\":\"删除标记 0:正常 1:删除\"},\"pageSize\":20,\"page\":1}")
public ApiResult save(@RequestBody String json) {
try {
return sysAreaService.saveReq(JSON.parseObject(json, SysAreaReq.class));
} catch (Exception e) {
log.error(e.getMessage(), e);
}
return ApiResult.error(ResultStatus.error.getCode(), MsgConstant.ERROR.getMsg());
}
/**
* 更新
* @param json
* @return ApiResult
*/
@PostMapping("update")
@ApiOperation(value="更新", notes="更新", response = SysArea.class)
@ApiImplicitParam(name = "json", value = "{{\"startRow\":0,\"parameter\":{\"id\":\"\",\"name\":\"简名\",\"fullName\":\"全名\",\"cIdx\":\"\",\"parentId\":\"上级id\",\"createBy\":\"创建人\",\"createTime\":\"创建时间\",\"updateBy\":\"修改人\",\"updateTime\":\"修改时间\",\"deleteFlag\":\"删除标记 0:正常 1:删除\"},\"pageSize\":20,\"page\":1}}")
public ApiResult update(@RequestBody String json) {
try {
return sysAreaService.updateReq(JSON.parseObject(json, SysAreaReq.class));
} catch (Exception e) {
log.error(e.getMessage(), e);
}
return ApiResult.error(ResultStatus.error.getCode(), MsgConstant.ERROR.getMsg());
}
/**
* 批量删除
* @return ApiResult
*/
@ApiOperation(value="批量删除", notes="批量删除")
@ApiImplicitParam(name = "json", value = "[1,2,3]")
public ApiResult delByIds(@RequestBody String json) {
try {
return sysAreaService.delByIds(JSONArray.parseArray(json,Long.class));
} catch (Exception e) {
log.error(e.getMessage(), e);
}
return ApiResult.error(ResultStatus.error.getCode(), MsgConstant.ERROR.getMsg());
}
/**
* 分页列表查询
* @param json
* @return ApiResult
*/
@PostMapping("pageList")
@ApiOperation(value = "分页查询",notes = "分页查询",response = SysArea.class)
@ApiImplicitParam(name = "json", value = "{\"id\":\"\",}")
public ApiResult pageList(@RequestBody(required = false) String json) {
log.debug("sysArea pageList: "+ json);
QueryReq queryReq = null;
try {
queryReq = buildQueryReq(json);
PageList<SysArea> pageList = (PageList<SysArea>) sysAreaService.pageList(queryReq);
return ApiResult.success(pageList);
} catch (Exception e) {
log.error(e.getMessage(), e);
}
return ApiResult.error(ResultStatus.error.getCode(), MsgConstant.INQUIRE_FAILURE.getMsg());
}
public static void main(String[] args) {
try {
//实体类转换json数据
//true表示分页格式:{"parameter":{"id":123},"page":当前页,"pageSize":页大小}
//false格式:{"id":123}
coverToJson(false, SysArea.class);
} catch (Exception e) {
log.error(e.getMessage(), e);
}
}
}
下面是我写的代码，都用post是因为公司规定
@Slf4j
@RestController
@RequestMapping("/login")
@Api(tags = "登录管理", value = "用户登录信息接口")
@RequiredArgsConstructor
public class LoginController {
private final SysUserService sysUserService;
private final SysRoleService sysRoleService;
@PostMapping("/getLoginUser")
@ApiOperation(value = "通过用户名查询", notes = "通过用户名查询", response = SysUser.class)
@ApiImplicitParams({@ApiImplicitParam(name = "username", value = "用户名", required = true)})
public ApiResult<SysUser> getUserInfo(@RequestBody String username) {
return new ApiResult<>(sysUserService.queryUserName(username));
}
@PostMapping("/getLoginUserMenuList")
@ApiOperation(value = "通过用户id查询菜单", notes = "通过用户id查询菜单", response = SysMenu.class)
@ApiImplicitParams({@ApiImplicitParam(name = "userId", value = "用户id", required = true)})
public ApiResult<List<SysMenu>> getLoginUserMenuList(@RequestBody Long userId) {
return new ApiResult<>(sysRoleService.selectRolePermissionByUserId(userId));
}
@PostMapping("/queryListRoleBaseUserId")
@ApiOperation(value = "通过用户id查询角色", notes = "通过用户id查询角色", response = SysRole.class)
@ApiImplicitParams({@ApiImplicitParam(name = "userId", value = "用户id", required = true)})
public ApiResult<List<SysRole>> queryListRoleBaseUserId(@RequestBody Long userId) {
return new ApiResult<>(sysRoleService.queryListRoleBaseUserId(userId));
}
}
