在HTML页面中编写PHP代码的优选方法？ [关闭]

Question

I'm wondering if there is a standard rule or method when trying to construct a dynamic html page that consist of both html and php.

For example most of the time I code whatever pops up on my head and my php will end up looking like this:

<div class="front-title-blocks">
      <div class="table">
        <div class="table-row">

            <?php while ($wp_query->have_posts()) : $wp_query->the_post(); 
                if( have_rows('table_row') ):
                   while ( have_rows('table_row') ) : the_row(); ?>
                            <div class="table-cell">
                                <?php the_sub_field('single_cell'); ?>
                            </div> 
                    <?php endwhile; else :
                        // no row found
                endif; ?>
            <?php endwhile;  ?>

        </div>
      </div>
</div>

Then I noticed the same code that carried out the exact same function can be re-written like this.

<?php

while ($wp_query->have_posts()) : $wp_query->the_post();
    function repeaterField(){
            $output='';
            if( have_rows('table-b-table') ):
                while ( have_rows('table_row') ) : the_row();
                        $output .= "<div class='table-cell'>".get_sub_field('single_cell')."</div>";
                 endwhile; else : // no row found
            endif;
            return $output;
    }

    $output = "<div class='front-title-blocks'>
                  <div class='table'>
                       <div class='table-row'>".repeaterField()."</div>
                   </div>
                </div>";
endwhile; 

echo $output;

?>

The difference that I noticed:

• First example has multiple opening and closing php tag that switch between html and php continuously.

• Second example tend use php all the way and can be echo out easily using a variable.

• Second example took longer time to construct and rearrange.

• For arrangement sake I feel like second one is more organize but I do notice that the first example is easier to read though.

Any advise would be appreciated.

Answer 1

The first option it's 'better' (or I prefered this) for various reasons: because it's more readable, with code editors you could have syntaxis help and autocomplete and the page loads faster.

Another thing to consider is that you will be dealing with double and simple quotes in the second method that could cause errors:

echo "<div id='a'"+$var+"'...>";

But the 2 options are valid.

There are others questions like that: Outputting HTML with echo considered bad practice in PHP?