This is my code so far, i changed it according to many posts i found on stackoverflow, however i can't seem to be able to make it work, it works fine, but sometimes it is stuck on the progress bar and it keeps spinning until the app crashes, i am trying to set the timeout so that if the connection is not successful it will stop instead of having the app crash .
I'm not sure if i am using the HttpConnectionParams.setSoTimeout and HttpConnectionParams.setConnectionTimeout the right way,
this is the JSON code
public JSONObject makeHttpRequest(String url, String method,List<NameValuePair> params)
{
try
{
HttpParams httpParameters = new BasicHttpParams();
HttpConnectionParams.setSoTimeout(httpParameters, 4000);
HttpConnectionParams.setConnectionTimeout(httpParameters, 4000);
if(method.equals("POST"))
{
HttpClient httpClient = new DefaultHttpClient(httpParameters);
HttpPost httpPost = new HttpPost(url);
httpPost.setEntity(new UrlEncodedFormEntity(params,"utf-8"));
HttpResponse httpResponse = httpClient.execute(httpPost);
HttpEntity httpEntity = httpResponse.getEntity();
if (httpEntity != null)
{
is = httpEntity.getContent();
if(is != null)
{
BufferedReader reader = new BufferedReader(new InputStreamReader(is, "utf-8"), 8);
StringBuilder sb = new StringBuilder();
String line = null;
while ((line = reader.readLine()) != null)
{
sb.append(line + "
");
}
is.close();
json = sb.toString();
jObj = new JSONObject(json);
}
}
}
else if(method.equals("GET"))
{
HttpClient httpClient = new DefaultHttpClient();
String paramString = URLEncodedUtils.format(params, "utf-8");
url += "?" + paramString;
HttpGet httpGet = new HttpGet(url);
HttpResponse httpResponse = httpClient.execute(httpGet);
HttpEntity httpEntity = httpResponse.getEntity();
if (httpEntity != null)
{
is = httpEntity.getContent();
if(is != null)
{
BufferedReader reader = new BufferedReader(new InputStreamReader(is, "utf-8"), 8);
StringBuilder sb = new StringBuilder();
String line = null;
while ((line = reader.readLine()) != null)
{
sb.append(line + "
");
}
is.close();
json = sb.toString();
jObj = new JSONObject(json);
}
}
}
}
catch (ConnectTimeoutException e)
{
//Here Connection TimeOut excepion
Log.e("connection error time OUT", "ok");
}
catch (UnsupportedEncodingException e)
{
e.printStackTrace();
} catch (ClientProtocolException e)
{
e.printStackTrace();
} catch (IOException e)
{
e.printStackTrace();
}
catch (Exception e)
{
Log.e("Buffer Error", "error converting result " + e.toString());
}
return jObj;
}
And this is the AsyncTask To load items from the php page.
class GetSpecialOffers extends AsyncTask<String, String, String> {
@Override
protected void onPreExecute() {
super.onPreExecute();
pDialog = new ProgressDialog(getActivity());
pDialog.setMessage("loading items, please wait...");
pDialog.setIndeterminate(false);
pDialog.setCancelable(false);
pDialog.show();
}
@Override
protected String doInBackground(String... args) {
List<NameValuePair> params = new ArrayList<NameValuePair>();
try
{
int success=0;
JSONObject json = jParser.makeHttpRequest(url_items, "GET",params);
if(json != null)
{
success = json.getInt(TAG_SUCCESS);
}
if (success == 1)
{
successValue = 1;
items = json.getJSONArray(TAG_SPECIAL_ITEM);
for (int i = 0; i < items.length(); i++)
{
JSONObject c = items.getJSONObject(i);
specialid = c.getString(TAG_SPECIAL_ID);
specialname = c.getString(TAG_SPECIAL_NAME);
specialprice = c.getString(TAG_SPECIAL_PRICE);
specialimage = c.getString(TAG_SPECIAL_IMAGE);
specialdate = c.getString(TAG_SPECIAL_DATE);
HashMap<String, String> map = new HashMap<String, String>();
map.put(TAG_SPECIAL_ID, specialid);
map.put(TAG_SPECIAL_NAME, specialname);
map.put(TAG_SPECIAL_PRICE, specialprice);
map.put(TAG_SPECIAL_IMAGE, specialimage);
map.put(TAG_SPECIAL_DATE, specialdate);
SpecialList.add(map);
}
}
else
{
successValue = 0;
}
}
catch (JSONException e)
{
e.printStackTrace();
}
return null;
}
protected void onPostExecute(String file_url)
{
pDialog.cancel();
if (successValue==1)
{
adapter = new SpecialAdapter(getActivity(), SpecialList);
lVSpecial.setAdapter(adapter);
}
else
{
NoSpecialOffersFound();
}
}
}