PHP OOP代码运行良好。 这是正确的做法吗？ 未来的一些发布会破坏它吗？

Question

Code snippet for class lnemail_fetch

<?php  Part of heritage_classes.php
// Declare classes
class lnemail_fetch {
// return string in format "title | factoid" 
    public  $result;
    public function get_ln_info() 
    {
    include ("./includes/LOheritage-config.php");
    mysql_connect("$dbhost", "$dbuser", "$dbpass") or die(mysql_error());
    mysql_select_db("$dbname") or die(mysql_error());
      $query = "SELECT * FROM lnemail";
     $result = mysql_query($query);
         $this->result = $result;
    }
}
?>

Code Snippet from larger program It lists a MySQL table

    require_once('./includes/heritage_classes.php'); 

    $newlnemail_fetch = new  lnemail_fetch;
     $newlnemail_fetch->get_ln_info();
     $newresult  = $newlnemail_fetch->result;
     echo  "lnemail File display  <br />"; 

      while($row = mysql_fetch_array($newresult))
        {
         echo $row['ln_email']. "  |  " . $row['ln_date'] . "  |  " . $row['ln_week'] ;
          echo "<br />";

        }

Is this use of PHP OOP considered good practice even though it works nicely for now?

Answer 1

I would say no, it's no good use of OOP.

Areas for improvement:

Separate the db connection and query stuff. Separate the db result handling. Implementing a result object that is iterable will be a good idea. Not using the mysql extension and switching to mysqli is a very good idea. It will also give you an OOP interface to MySQL for free.

Probably aspects of escaping input inside SQL strings should be considered, but this is undecidable because no such code has been shown.