PHP删除错误

Question

I have a dropdown list populated with files pulled from a directory using the PHP listed below and am trying to figure out how I can delete them using a delete button in the form when they're selected.

EDIT Unlink function error resolved.

Still getting error when trying to delete: Error.array(1) { ["Action"]=> string(6) "Delete" }

<input type="hidden" name="Action" value="EDIT" /><input type="hidden" name="Selection"  id="Selection" value="-1"><div>Below is the list of your saved codes. To edit your codes, select it from the list.</div>
<select size="1" name="CodeList" id="CodeList">
<?php
   $directory = $directory = 'users/' . $_SESSION['username'];
   $filesContents = Array();
   $files = scandir( $directory ) ;

    foreach( $files as $file )
   {
  if ( ! is_dir( $file ) )
 {
   $filesContents[$file] = file_get_contents($directory , $file);
      echo '<option value="'. $file .'">' . $file . '</option>';
   }
  }
?>

delete php script.

   <?php
   session_start();
    $directory = $directory = $_SERVER['DOCUMENT_ROOT'] . '/users/' .      $_SESSION['username'];
    $file_to_delete = $_POST['CodeList'];
    if(is_file($directory .'/'. $file_to_delete) && is_writable($directory .'/'. $file_to_delete)) {
    if ( unlink ($directory.'/'.$file_to_delete) ) {
      echo $file_to_delete . " deleted.";
    } else {
  echo "Error.";
  }
 }
?>
<?php var_dump($_POST) ?>

Answer 1

You add the options, but no option value. A selectbox should look like this:

<select name="identifier">
    <option value="value_1">Option 1</option>
    <option value="value_2">Option 2</option>
</select>

Now if you select option 2, you should get value_2 in your post array:

echo $_POST['identifier']; // prints out 'value_2';

Your options look like: <option>Option x</option>, which means you select an option, but it has no value (no value="" attribute).

If you look at your PHP error, I do see a correct directory name, but there is no filename appended.

You should also check if the file exists, to prevent a "no such file" error:

if(is_file($directory .'/'. $file_to_be_deleted) && is_writable($directory .'/'. $file_to_be_deleted)) {
    // delete the file
}

Yes, I use the is_file AND the is_writable test, because the is_writable function will also return true if the checked path is a directory.

EDIT

To assign values, alter your foreach loop as follows:

<select size="1" name="CodeList" id="CodeList">
    <?php
    // fetch files etc.

    foreach( $files as $file ) {
        if ( ! is_dir( $file ) {
            echo '<option value="'. $file .'">' . $file . '</option>';
        }
    }

Oh and btw: get rid of the get_file_contents() part. You don't do anything with the contents of the file there, do you?