I'm teaching myself PHP so this is probably something stupid I don't know yet, but why is my redirect not working...
I'm trying to do this:
header("Location: members.php?view=$user"); exit;
which doesn't do anything, but when I place a link in die statement upon successful login
die("You are now logged in. Please <a href='members.php?view=$user'>click here</a> to continue.");
I can click on that link and it works fine.
Full Code
<?php //login.php
include_once 'header.php';
echo "<div class='main'><h3>Please enter your details to log in</h3>";
$error = $user = $pass = "";
if (isset($_POST['user'])) {
$user = sanitizeString($_POST['user']);
$pass = sanitizeString($_POST['pass']);
if ($user == "" || $pass == "") {
$error = "Not all fields were entered<br />";
}
else {
$query = "SELECT user,pass FROM members WHERE user='$user' AND pass='$pass'";
if (mysql_num_rows(queryMysql($query)) == 0) {
$error = "<span class='error'>Username/Password invalid</span><br /><br />";
}
else {
$_SESSION['user'] = $user;
$_SESSION['pass'] = $pass;
header("Location: members.php?view=$user"); exit;
}
}
}
echo <<<_END
<form method='post' action='login.php'>$error
<span class='fieldname'>Username</span><input type='text' maxlength='16' name='user' value='$user' /><br />
<span class='fieldname'>Password</span><input type='password' maxlength='16' name='pass' value='$pass' />
_END;
?>
<br />
<span class='fieldname'> </span>
<input type='submit' value='Login' />
</form><br /></div></body></html>
<?php //header.php
session_start();
echo "<!DOCTYPE html>
<html><head><script src='js/osc.js'></script>";
include 'functions.php';
$userstr = ' (Guest)';
if (isset($_SESSION['user'])) {
$user = $_SESSION['user'];
$loggedin = TRUE;
$userstr = " ($user)";
}
else {
$loggedin = FALSE;
}
echo "<title>$appname$userstr</title><link href='css/main.css' rel='stylesheet' type='text/css' />" .
"</head><body><div class='$appname'>$appname$userstr</div>";
if ($loggedin) {
echo "<br /><ul class='menu'>" .
"<li><a href='members.php?view=$user'>Home</a></li>" .
"<li><a href='members.php'>Members</a></li>" .
"<li><a href='friends.php'>Friends</a></li>" .
"<li><a href='messages.php'>Messages</a></li>" .
"<li><a href='profile'>Edit Profile</a></li>" .
"<li><a href='logout.php'>Log Out</a></li></ul><br />";
}
else {
echo ("<br /><ul class='menu'>" .
"<li><a href='index.php'>Home</a></li>" .
"<li><a href='signup.php'>Sign Up</a></li>" .
"<li><a href='login.php'>Log In</a></li></ul><br />" .
"<span class='info'>⇎ You must be logged in to view this page.</span><br /><br />"
);
}
?>
I've tried removing the first echo at the top, as well as the $error message. Like I said, I'm trying to improve on some code I picked up from this O'Reilly book, so I appreciate any help, guidance, criticism, etc.
