我应该如何在try / catch块中修复此代码气味

Question

OK. I get a code smell warning in my IDE. I understand why, and understand that the warning isn't especially dire. However, if there is a better way to write this block, I would like to know.

public function factory($state_name = 'Generic')
{
    ...

    try {
        if (!$class_exists) {
            throw new CustomException;
        } else {
            return new $class_name;
        }
    }
    catch (CustomException $c) {
        echo ...
    }

}

I don't return a value outside of the try block. Smell goes away if I return one at the end. Is there a better way to do this?

Answer 1

The bigger code smell for me is that you are throwing an exception and then immediately catching it. It seems that you are doing this to avoid returning anything, which of course, your IDE is complaining about. I would rewrite this as:

public function factory($state_name = 'Generic')
{
    ...

    if ($class_exists) {
        return new $class_name;
    }
    return null;

}