duandingqi9442 2014-06-22 10:39
浏览 14
已采纳

是否应该以这种方式使用switch语句? [关闭]

Is it acceptable to use a switch as a way of supporting multiple file formats, or is it bad practice?

Like so (untested):

<?php

    // Load file
    switch ($data_format) {
        case 'xml':
            $openfile = simplexml_load_file($filename . '.xml');
            break;

        case 'json':
            $openfile = json_decode(file_get_contents($filename . '.json'));
            break;
    }

    // Do stuff

    // Save file
    switch ($data_format) {
        case 'xml':
            $openfile->asXML($filename . '.xml');
            break;

        case 'json':
            file_put_contents($filename . '.json', json_encode($openfile, JSON_PRETTY_PRINT));
            break;
    }

?>
  • 写回答

1条回答 默认 最新

  • dongqianchi0512 2014-06-22 10:52
    关注

    It depends on your style of coding. If you want to work object oriented then this would be against the idea. In this case you'd use something like:

    $file = $repository->open($filename, $data_format);
    // do stuff
    $file->save();
    

    Of course $repository->open() needs to return an object with a different save method depending on your data format.

    However if you are not working object oriented but good old procedural style I cannot see anything wrong with your use of the switch statement.

    本回答被题主选为最佳回答 , 对您是否有帮助呢?
    评论

报告相同问题?

悬赏问题

  • ¥15 flink cdc无法实时同步mysql数据
  • ¥100 有人会搭建GPT-J-6B框架吗?有偿
  • ¥15 求差集那个函数有问题,有无佬可以解决
  • ¥15 【提问】基于Invest的水源涵养
  • ¥20 微信网友居然可以通过vx号找到我绑的手机号
  • ¥15 寻一个支付宝扫码远程授权登录的软件助手app
  • ¥15 解riccati方程组
  • ¥15 使用rabbitMQ 消息队列作为url源进行多线程爬取时,总有几个url没有处理的问题。
  • ¥15 Ubuntu在安装序列比对软件STAR时出现报错如何解决
  • ¥50 树莓派安卓APK系统签名