将PDO与SELECT选项一起使用

Question

I'm trying to use PDO for a SELECT Option, this is my functions.php code:

<?php
    class Benefits
    {
        public function fetch_all()
        {
            global $pdo;

            $benfitssql = $pdo->query('SELECT * FROM lkup_benefits');
            //$benfitssql->execute();

            while ($row = $benfitssql->fetch(PDO::FETCH_ASSOC))
            {
                $ops.= "<option value='" . $row['BenefitOption'] . "'>"
                    . $row['Benfits'] . "</option>";
            }
        }
    }
?>

This is my main page:

<label>Benefit Type</label>

<select class="select2_category form-control" data-placeholder="Choose a Category" tabindex="1" id="benefittype" name="benefittype">
    <?php echo $ops; ?>
</select>

When I select the SELECT Option, it opens with no records, why would this be, what have I missed?

Answer 1

There are two essential flaws with your code

first, you should never format HTML inside of a function,
second, you should return something from the function

class Benefits {
    public function fetch_all() {
        global $pdo;
        return $pdo->query('SELECT * FROM lkup_benefits') ->fetchAll();
    }
}
?>
<label>Benefit Type</label>
<select class="select2_category form-control" data-placeholder="Choose a Category" tabindex="1" id="benefittype" name="benefittype">
<?php foreach ($benefits->fetch_all() as $row): ?>
    <option value="<?=$row['BenefitOption']?>"><?=$row['Benfits']?></option>
<?php endforeach ?>
</select>